* CVE-2026-72121: can: bcm: add locking when updating filter and timer values
@ 2026-08-15 6:03 Greg Kroah-Hartman
0 siblings, 0 replies; only message in thread
From: Greg Kroah-Hartman @ 2026-08-15 6:03 UTC (permalink / raw)
To: linux-cve-announce; +Cc: Greg Kroah-Hartman
From: Greg Kroah-Hartman <gregkh@kernel.org>
Description
===========
In the Linux kernel, the following vulnerability has been resolved:
can: bcm: add locking when updating filter and timer values
KCSAN detected a simultaneous access to timer values that can be
overwritten in bcm_rx_setup() when updating timer and filter content
while bcm_rx_handler(), bcm_rx_timeout_handler() or bcm_rx_thr_handler()
run concurrently on incoming CAN traffic.
Protect the timer (ival1/ival2/kt_ival1/kt_ival2/kt_lastmsg) and filter
(nframes/flags/frames/last_frames) updates in bcm_rx_setup() with a new
per-op bcm_rx_update_lock, taken with the matching scope in the RX
handlers. memcpy_from_msg() is staged into a temporary buffer before the
lock is taken, since it can sleep and must not run under a spinlock.
hrtimer_cancel() is always called without bcm_rx_update_lock held, since
bcm_rx_timeout_handler()/bcm_rx_thr_handler() take the same lock and a
running callback would otherwise deadlock against the canceller.
Also close a related race: bcm_rx_setup() cleared the RTR flag in the
stored reply frame's can_id as a separate, unprotected step after the
frame content was already installed, so a concurrent bcm_rx_handler()
could transmit a stale reply with CAN_RTR_FLAG still set. Fold that
normalization into the initial frame preparation instead (on the staged
buffer for updates, directly on op->frames pre-registration for new
ops), so the installed frame is always atomically self-consistent.
bcm_rx_handler()'s RX_RTR_FRAME check now takes a lock-protected
snapshot of op->flags before deciding whether to call bcm_can_tx(),
but does not hold the lock across that call.
Also take a lock-protected snapshot of the currframe in bcm_can_tx()
to avoid partly overwrites by content updates in bcm_tx_setup().
Finally check if a TX_RESET_MULTI_IDX/SETTIMER might have reset
op->currframe between the two locked sections in bcm_can_tx().
Omit calling hrtimer_forward() with zero interval in bcm_rx_thr_handler().
kt_ival2 may have been concurrently cleared by bcm_rx_setup() before it
cancels this timer, so check kt_ival2 inside the bcm_rx_update_lock.
The Linux kernel CVE team has assigned CVE-2026-72121 to this issue.
Affected and fixed versions
===========================
Issue introduced in 6.6.93 with commit 76c84c3728178b2d38d5604e399dfe8b0752645e and fixed in 6.6.148 with commit a7eb6db1cd3f7b556a301dc1265945ad112089f7
Issue introduced in 6.12.31 with commit cc55dd28c20a6611e30596019b3b2f636819a4c0 and fixed in 6.12.101 with commit 834cbca3b12e46887f7a9b35f1981a888360ea4c
Issue introduced in 6.15 with commit c2aba69d0c36a496ab4f2e81e9c2b271f2693fd7 and fixed in 6.18.42 with commit 19b1994069dd29478ba767de1f98f14a088198dc
Issue introduced in 6.15 with commit c2aba69d0c36a496ab4f2e81e9c2b271f2693fd7 and fixed in 7.1.5 with commit fc9f5ee1b073bd233d9c604e338af4ebb42cbc33
Issue introduced in 6.15 with commit c2aba69d0c36a496ab4f2e81e9c2b271f2693fd7 and fixed in 7.2-rc4 with commit 749179c2e25b95d22499ed29096b3e02d6dfd2b4
Issue introduced in 5.4.294 with commit 8f1c022541bf5a923c8d6fa483112c15250f30a4
Issue introduced in 5.10.238 with commit 7595de7bc56e0e52b74e56c90f7e247bf626d628
Issue introduced in 5.15.185 with commit fbd8fdc2b218e979cfe422b139b8f74c12419d1f
Issue introduced in 6.1.141 with commit 2a437b86ac5a9893c902f30ef66815bf13587bf6
Issue introduced in 6.14.9 with commit c4e8a172501e677ebd8ea9d9161d97dc4df56fbd
Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.
Unaffected versions might change over time as fixes are backported to
older supported kernel versions. The official CVE entry at
https://cve.org/CVERecord/?id=CVE-2026-72121
will be updated if fixes are backported, please check that for the most
up to date information about this issue.
Affected files
==============
The file(s) affected by this issue are:
net/can/bcm.c
Mitigation
==========
The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes. Individual
changes are never tested alone, but rather are part of a larger kernel
release. Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all. If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
https://git.kernel.org/stable/c/a7eb6db1cd3f7b556a301dc1265945ad112089f7
https://git.kernel.org/stable/c/834cbca3b12e46887f7a9b35f1981a888360ea4c
https://git.kernel.org/stable/c/19b1994069dd29478ba767de1f98f14a088198dc
https://git.kernel.org/stable/c/fc9f5ee1b073bd233d9c604e338af4ebb42cbc33
https://git.kernel.org/stable/c/749179c2e25b95d22499ed29096b3e02d6dfd2b4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-15 6:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-15 6:03 CVE-2026-72121: can: bcm: add locking when updating filter and timer values Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.