All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: olteanv@gmail.com, robh@kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	neil.armstrong@linaro.org, vkoul@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 3/9] dt-bindings: usb: generic-ehci: Document access-controllers property
Date: Sun, 16 Aug 2026 21:46:38 +0000	[thread overview]
Message-ID: <20260816214639.4A1B11F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260816213849.1044073-4-marex@nabladev.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch adds the `access-controllers` property to `generic-ehci.yaml` but fails to update the companion `generic-ohci.yaml` binding schema.
--

--- Patch [3]: [PATCH v2 3/9] dt-bindings: usb: generic-ehci: Document access-controllers property ---
commit 53582485218bdac0220f3acaf5124a6d9549f7b3
Author: Marek Vasut <marex@nabladev.com>

dt-bindings: usb: generic-ehci: Document access-controllers property

This commit updates the generic EHCI device tree binding to document the
access-controllers property for controllers that require access checks.

> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index 55a5aa7d7a54e..602241887d995 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -80,6 +80,9 @@ properties:
>      minItems: 1
>      maxItems: 2
>  
> +  access-controllers:
> +    maxItems: 1
> +

[Severity: Medium]
Should Documentation/devicetree/bindings/usb/generic-ohci.yaml also be
updated symmetrically?

When access-controllers are configured for the companion OHCI controller
in the device tree (such as on STMicroelectronics SoCs where EHCI and OHCI
operate as firewalled companions), wouldn't the dt_binding_check validation
fail since generic-ohci.yaml enforces unevaluatedProperties: false?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260816213849.1044073-1-marex@nabladev.com?part=3

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: olteanv@gmail.com, robh@kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	neil.armstrong@linaro.org, vkoul@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 3/9] dt-bindings: usb: generic-ehci: Document access-controllers property
Date: Sun, 16 Aug 2026 21:46:38 +0000	[thread overview]
Message-ID: <20260816214639.4A1B11F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260816213849.1044073-4-marex@nabladev.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch adds the `access-controllers` property to `generic-ehci.yaml` but fails to update the companion `generic-ohci.yaml` binding schema.
--

--- Patch [3]: [PATCH v2 3/9] dt-bindings: usb: generic-ehci: Document access-controllers property ---
commit 53582485218bdac0220f3acaf5124a6d9549f7b3
Author: Marek Vasut <marex@nabladev.com>

dt-bindings: usb: generic-ehci: Document access-controllers property

This commit updates the generic EHCI device tree binding to document the
access-controllers property for controllers that require access checks.

> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index 55a5aa7d7a54e..602241887d995 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -80,6 +80,9 @@ properties:
>      minItems: 1
>      maxItems: 2
>  
> +  access-controllers:
> +    maxItems: 1
> +

[Severity: Medium]
Should Documentation/devicetree/bindings/usb/generic-ohci.yaml also be
updated symmetrically?

When access-controllers are configured for the companion OHCI controller
in the device tree (such as on STMicroelectronics SoCs where EHCI and OHCI
operate as firewalled companions), wouldn't the dt_binding_check validation
fail since generic-ohci.yaml enforces unevaluatedProperties: false?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260816213849.1044073-1-marex@nabladev.com?part=3

  reply	other threads:[~2026-08-16 21:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-16 21:37 [PATCH v2 0/9] arm64: dts: phy: st: usb: Add STM32MP2 USB support Marek Vasut
2026-08-16 21:37 ` Marek Vasut
2026-08-16 21:37 ` [PATCH v2 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY Marek Vasut
2026-08-16 21:37   ` Marek Vasut
2026-08-16 21:37 ` [PATCH v2 2/9] phy: stm32: Add support for " Marek Vasut
2026-08-16 21:37   ` Marek Vasut
2026-08-16 21:50   ` sashiko-bot
2026-08-16 21:50     ` sashiko-bot
2026-08-16 21:37 ` [PATCH v2 3/9] dt-bindings: usb: generic-ehci: Document access-controllers property Marek Vasut
2026-08-16 21:37   ` Marek Vasut
2026-08-16 21:46   ` sashiko-bot [this message]
2026-08-16 21:46     ` sashiko-bot
2026-08-16 21:37 ` [PATCH v2 4/9] dt-bindings: usb: generic-ohci: " Marek Vasut
2026-08-16 21:37   ` Marek Vasut
2026-08-16 21:37 ` [PATCH v2 5/9] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller Marek Vasut
2026-08-16 21:37   ` Marek Vasut
2026-08-16 21:47   ` sashiko-bot
2026-08-16 21:47     ` sashiko-bot
2026-08-16 21:37 ` [PATCH v2 6/9] usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue Marek Vasut
2026-08-16 21:37   ` Marek Vasut
2026-08-16 21:37 ` [PATCH v2 7/9] dt-bindings: arm: stm32: Switch st,stm32mp23/25-syscfg into simple-mfd Marek Vasut
2026-08-16 21:37   ` Marek Vasut
2026-08-16 21:50   ` sashiko-bot
2026-08-16 21:50     ` sashiko-bot
2026-08-16 21:37 ` [PATCH v2 8/9] arm64: dts: st: Add USB nodes on stm32mp231 Marek Vasut
2026-08-16 21:37   ` Marek Vasut
2026-08-16 21:37 ` [PATCH v2 9/9] arm64: dts: st: Add USB nodes on stm32mp251 Marek Vasut
2026-08-16 21:37   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260816214639.4A1B11F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=marex@nabladev.com \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.