Re: [LTP] pmc_core: add test for pkgc_blocker_residency_show

[linuxtestproject.agent@gmail.com]

Hi Piotr,

On Mon, 17 Aug 2026 08:40:53 +0200, Piotr Kubaj wrote:
> pmc_core: add test for pkgc_blocker_residency_show

> + * telemetry region behind these counters refreshes at roughly 1s granularity
> + * on Nova Lake, so the retries end within about a second. Two seconds is
> + * enough headroom that a sample which observed no refresh at all means "every
> + * source idle" rather than "polled too early".

> +	differs = TST_RETRY_FN_EXP_BACKOFF(second_sample_differs(),
> +					   TST_RETVAL_NOTNULL, MAX_SAMPLE_DELAY);
> +
> +	tst_clock_gettime(CLOCK_MONOTONIC, &end);
> +
> +	elapsed_us = tst_timespec_diff_us(end, start);

Could the bound account for the age of an asynchronous telemetry snapshot?
If the first read occurs just before a roughly one-second refresh, the retry
can observe about 100000 ticks accumulated during the previous second after
only microseconds of measured time. Since the retry stops at the first change,
the factor-of-two slack still reports a valid update as implausible.

Could the test establish a refresh-aligned baseline and measure the following
update, or add a justified refresh-age allowance to the bound?

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp