* dma_opt_mapping_size returns way too low sizes when using IOMMU
@ 2026-08-17 8:36 Christoph Hellwig
2026-08-17 9:12 ` John Garry
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2026-08-17 8:36 UTC (permalink / raw)
To: Marek Szyprowski, Robin Murphy, Joerg Roedel, Will Deacon,
John Garry, iommu, linux-nvme
Hi all,
I got reports that NVMe devices were arbitrarily limited to 128kiB
transfers in recent kernel. It turns out that this only happens when
using an IOMMU and is caused by iommu_dma_opt_mapping_size returning
iova_rcache_range(), which is defined as follows:
unsigned long iova_rcache_range(void)
{
return PAGE_SIZE << (IOVA_RANGE_CACHE_MAX_SIZE - 1);
}
and thus indeed hardcodes a 128kiB return on 4k page size architectures.
Both the NVMe performance numbers and common sense suggest that this
is NOT the optimal DMA mapping granularity. Can we pick a saner value
for iommu_dma_opt_mapping_size that does not restrict common I/O sizes?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: dma_opt_mapping_size returns way too low sizes when using IOMMU 2026-08-17 8:36 dma_opt_mapping_size returns way too low sizes when using IOMMU Christoph Hellwig @ 2026-08-17 9:12 ` John Garry 2026-08-17 9:18 ` Christoph Hellwig 0 siblings, 1 reply; 5+ messages in thread From: John Garry @ 2026-08-17 9:12 UTC (permalink / raw) To: Christoph Hellwig, Marek Szyprowski, Robin Murphy, Joerg Roedel, Will Deacon, iommu, linux-nvme On 17/08/2026 09:36, Christoph Hellwig wrote: > Hi all, > > I got reports that NVMe devices were arbitrarily limited to 128kiB > transfers in recent kernel. How recent a kernel? This NVMe and DMA mapping code has not changed in years as far as I know. > It turns out that this only happens when > using an IOMMU and is caused by iommu_dma_opt_mapping_size returning > iova_rcache_range(), which is defined as follows: > > unsigned long iova_rcache_range(void) > { > return PAGE_SIZE << (IOVA_RANGE_CACHE_MAX_SIZE - 1); > } > > and thus indeed hardcodes a 128kiB return on 4k page size architectures. > > Both the NVMe performance numbers and common sense suggest that this > is NOT the optimal DMA mapping granularity. Can we pick a saner value > for iommu_dma_opt_mapping_size that does not restrict common I/O sizes? Note that SCSI does not use iommu_dma_opt_mapping_size() for clamping max HW sectors, but instead sets opt size / max sectors from this value (so it is not a hard limit there). Could we consider similar for NVMe? The reason for which we have iommu_dma_opt_mapping_size() is that performance can go through the floor we can't use the rcache for getting the IOVA, i.e. we need to always alloc and dealloc an IOVA from the RB tree for each mapping, and this can greatly reduce performance when the IOVA space fills. If we increase IOVA_RANGE_CACHE_MAX_SIZE, then we just get caching of larger IOVAs and I am not sure that is a great idea. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: dma_opt_mapping_size returns way too low sizes when using IOMMU 2026-08-17 9:12 ` John Garry @ 2026-08-17 9:18 ` Christoph Hellwig 2026-08-17 10:11 ` John Garry 0 siblings, 1 reply; 5+ messages in thread From: Christoph Hellwig @ 2026-08-17 9:18 UTC (permalink / raw) To: John Garry Cc: Christoph Hellwig, Marek Szyprowski, Robin Murphy, Joerg Roedel, Will Deacon, iommu, linux-nvme On Mon, Aug 17, 2026 at 10:12:25AM +0100, John Garry wrote: > On 17/08/2026 09:36, Christoph Hellwig wrote: >> Hi all, >> >> I got reports that NVMe devices were arbitrarily limited to 128kiB >> transfers in recent kernel. > > How recent a kernel? This NVMe and DMA mapping code has not changed in > years as far as I know. This was hardware QA moving from an old distro kernel to a "recent" (aka still old) one. But I've actually reproduced it locally on an upstream kernel. I guess most kernel developers or power users simply do not run with IOMMU enabled. >> Both the NVMe performance numbers and common sense suggest that this >> is NOT the optimal DMA mapping granularity. Can we pick a saner value >> for iommu_dma_opt_mapping_size that does not restrict common I/O sizes? > > Note that SCSI does not use iommu_dma_opt_mapping_size() for clamping max > HW sectors, but instead sets opt size / max sectors from this value (so it > is not a hard limit there). Could we consider similar for NVMe? We could consider that, but it would still reduce performane.. > The reason for which we have iommu_dma_opt_mapping_size() is that > performance can go through the floor we can't use the rcache for getting > the IOVA, i.e. we need to always alloc and dealloc an IOVA from the RB tree > for each mapping, and this can greatly reduce performance when the IOVA > space fills. > > If we increase IOVA_RANGE_CACHE_MAX_SIZE, then we just get caching of > larger IOVAs and I am not sure that is a great idea. At least on the four different nvme devices I tested, the larger I/O sizes made up for this. But maybe the details depend on other factors as well. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: dma_opt_mapping_size returns way too low sizes when using IOMMU 2026-08-17 9:18 ` Christoph Hellwig @ 2026-08-17 10:11 ` John Garry 2026-08-17 17:04 ` Robin Murphy 0 siblings, 1 reply; 5+ messages in thread From: John Garry @ 2026-08-17 10:11 UTC (permalink / raw) To: Christoph Hellwig Cc: Marek Szyprowski, Robin Murphy, Joerg Roedel, Will Deacon, iommu, linux-nvme On 17/08/2026 10:18, Christoph Hellwig wrote: > On Mon, Aug 17, 2026 at 10:12:25AM +0100, John Garry wrote: >> On 17/08/2026 09:36, Christoph Hellwig wrote: >>> Hi all, >>> >>> I got reports that NVMe devices were arbitrarily limited to 128kiB >>> transfers in recent kernel. >> >> How recent a kernel? This NVMe and DMA mapping code has not changed in >> years as far as I know. > > This was hardware QA moving from an old distro kernel to a "recent" (aka > still old) one. But I've actually reproduced it locally on an > upstream kernel. I guess most kernel developers or power users simply > do not run with IOMMU enabled. Yeah, they don't like any performance hit. > >>> Both the NVMe performance numbers and common sense suggest that this >>> is NOT the optimal DMA mapping granularity. Can we pick a saner value >>> for iommu_dma_opt_mapping_size that does not restrict common I/O sizes? >> >> Note that SCSI does not use iommu_dma_opt_mapping_size() for clamping max >> HW sectors, but instead sets opt size / max sectors from this value (so it >> is not a hard limit there). Could we consider similar for NVMe? > > We could consider that, but it would still reduce performane.. > >> The reason for which we have iommu_dma_opt_mapping_size() is that >> performance can go through the floor we can't use the rcache for getting >> the IOVA, i.e. we need to always alloc and dealloc an IOVA from the RB tree >> for each mapping, and this can greatly reduce performance when the IOVA >> space fills. >> >> If we increase IOVA_RANGE_CACHE_MAX_SIZE, then we just get caching of >> larger IOVAs and I am not sure that is a great idea. > > At least on the four different nvme devices I tested, the larger I/O > sizes made up for this. But maybe the details depend on other > factors as well. Are you saying that you tried increasing IOVA_RANGE_CACHE_MAX_SIZE and got better performance? As I remember, I was told that the value of 6 for IOVA_RANGE_CACHE_MAX_SIZE was originally chosen from the value then in max page order, i.e. the idea was that we should not be getting streaming IOs larger than that value. But in looking at lore, 8 was very originally proposed, but I can't see any discussion on why that changed or any relation to page max order. Some time ago I did try some work to allow IOVA_RANGE_CACHE_MAX_SIZE be set per IOMMU domain, but it was not merged. We went with dma_opt_mapping_size() solution instead. https://lore.kernel.org/linux-scsi/1620656249-68890-1-git-send-email-john.garry@huawei.com/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: dma_opt_mapping_size returns way too low sizes when using IOMMU 2026-08-17 10:11 ` John Garry @ 2026-08-17 17:04 ` Robin Murphy 0 siblings, 0 replies; 5+ messages in thread From: Robin Murphy @ 2026-08-17 17:04 UTC (permalink / raw) To: John Garry, Christoph Hellwig Cc: Marek Szyprowski, Joerg Roedel, Will Deacon, iommu, linux-nvme On 17/08/2026 11:11 am, John Garry wrote: > On 17/08/2026 10:18, Christoph Hellwig wrote: >> On Mon, Aug 17, 2026 at 10:12:25AM +0100, John Garry wrote: >>> On 17/08/2026 09:36, Christoph Hellwig wrote: >>>> Hi all, >>>> >>>> I got reports that NVMe devices were arbitrarily limited to 128kiB >>>> transfers in recent kernel. >>> >>> How recent a kernel? This NVMe and DMA mapping code has not changed >>> in years as far as I know. >> >> This was hardware QA moving from an old distro kernel to a "recent" (aka >> still old) one. But I've actually reproduced it locally on an >> upstream kernel. I guess most kernel developers or power users simply >> do not run with IOMMU enabled. > > Yeah, they don't like any performance hit. > >> >>>> Both the NVMe performance numbers and common sense suggest that this >>>> is NOT the optimal DMA mapping granularity. Can we pick a saner value >>>> for iommu_dma_opt_mapping_size that does not restrict common I/O sizes? >>> >>> Note that SCSI does not use iommu_dma_opt_mapping_size() for clamping >>> max HW sectors, but instead sets opt size / max sectors from this >>> value (so it is not a hard limit there). Could we consider similar >>> for NVMe? >> >> We could consider that, but it would still reduce performane.. > > >> The reason for which we have iommu_dma_opt_mapping_size() is that >>> performance can go through the floor we can't use the rcache for >>> getting the IOVA, i.e. we need to always alloc and dealloc an IOVA >>> from the RB tree for each mapping, and this can greatly reduce >>> performance when the IOVA space fills. >>> >>> If we increase IOVA_RANGE_CACHE_MAX_SIZE, then we just get caching of >>> larger IOVAs and I am not sure that is a great idea. >> >> At least on the four different nvme devices I tested, the larger I/O >> sizes made up for this. But maybe the details depend on other >> factors as well. > Are you saying that you tried increasing IOVA_RANGE_CACHE_MAX_SIZE and > got better performance? > > As I remember, I was told that the value of 6 for > IOVA_RANGE_CACHE_MAX_SIZE was originally chosen from the value then in > max page order, i.e. the idea was that we should not be getting > streaming IOs larger than that value. But in looking at lore, 8 was very > originally proposed, but I can't see any discussion on why that changed > or any relation to page max order. From a quick skim I can't spot any specific mention in the original threads or accompanying paper, but I have a feeling it was as much about just balancing memory consumption with observable performance improvement, and larger sizes weren't significantly impactful to the original testing, which did seem to be focused on networking rather than storage. Since these days we have the flexibly-sized depot, and now even lazy-allocation of the CPU magazines, we might be in a better position to consider scaling IOVA_RANGE_CACHE_MAX_SIZE up without too much inherent overhead (I guess the base cost per level will just be 2*NR_CPUS + 1 pointers now). The larger sizes we cache, though, the more it's also going to blow up IOVA consumption if freeing/reallocation isn't well balanced across CPUs, so for devices/systems with limited IOVA space, at some point the flush_rcache case is liable to start adding more overhead than the caching itself saves... FWIW, my understanding of the idea we settled on for opt_mapping_size was that it was never meant to be an absolute target, just a boundary between where callers can expect "ideal" mapping performance, and where it may start scaling with size/contention/etc., and thus it's for the callers to judge whether larger sizes are still worth it for their particular use-case. Thanks, Robin. > Some time ago I did try some work to allow IOVA_RANGE_CACHE_MAX_SIZE be > set per IOMMU domain, but it was not merged. We went with > dma_opt_mapping_size() solution instead. > > https://lore.kernel.org/linux-scsi/1620656249-68890-1-git-send-email- > john.garry@huawei.com/ > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-17 17:04 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-08-17 8:36 dma_opt_mapping_size returns way too low sizes when using IOMMU Christoph Hellwig 2026-08-17 9:12 ` John Garry 2026-08-17 9:18 ` Christoph Hellwig 2026-08-17 10:11 ` John Garry 2026-08-17 17:04 ` Robin Murphy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.