From: Jakub Kicinski <kuba@kernel.org>
To: Kshitiz Bartariya <kshitiz.bartariya@zohomail.in>
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net-next v5] ixgbe: implement get_queue_stats_rx
Date: Mon, 17 Aug 2026 16:43:08 -0700 [thread overview]
Message-ID: <20260817164308.5bf8bc87@kernel.org> (raw)
In-Reply-To: <20260814141446.90544-1-kshitiz.bartariya@zohomail.in>
On Fri, 14 Aug 2026 19:44:36 +0530 Kshitiz Bartariya wrote:
> +static void ixgbe_get_queue_stats_rx(struct net_device *dev, int idx,
> + struct netdev_queue_stats_rx *stats)
> +{
> + struct ixgbe_adapter *adapter = ixgbe_from_netdev(dev);
> + struct ixgbe_ring *ring = READ_ONCE(adapter->rx_ring[idx]);
> + u64 bytes, packets, alloc_rx_page_failed, alloc_rx_buff_failed,
> + csum_err;
> + unsigned int start;
> +
> + if (ring) {
> + do {
> + start = u64_stats_fetch_begin(&ring->syncp);
> + bytes = ring->stats.bytes;
> + packets = ring->stats.packets;
> + alloc_rx_page_failed =
> + ring->rx_stats.alloc_rx_page_failed;
> + alloc_rx_buff_failed =
> + ring->rx_stats.alloc_rx_buff_failed;
> + csum_err = ring->rx_stats.csum_err;
> + } while (u64_stats_fetch_retry(&ring->syncp, start));
> + }
> +
> + stats->bytes = bytes;
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:9772:6: warning: variable 'bytes' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
--
pw-not: cr
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Kshitiz Bartariya <kshitiz.bartariya@zohomail.in>
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5] ixgbe: implement get_queue_stats_rx
Date: Mon, 17 Aug 2026 16:43:08 -0700 [thread overview]
Message-ID: <20260817164308.5bf8bc87@kernel.org> (raw)
In-Reply-To: <20260814141446.90544-1-kshitiz.bartariya@zohomail.in>
On Fri, 14 Aug 2026 19:44:36 +0530 Kshitiz Bartariya wrote:
> +static void ixgbe_get_queue_stats_rx(struct net_device *dev, int idx,
> + struct netdev_queue_stats_rx *stats)
> +{
> + struct ixgbe_adapter *adapter = ixgbe_from_netdev(dev);
> + struct ixgbe_ring *ring = READ_ONCE(adapter->rx_ring[idx]);
> + u64 bytes, packets, alloc_rx_page_failed, alloc_rx_buff_failed,
> + csum_err;
> + unsigned int start;
> +
> + if (ring) {
> + do {
> + start = u64_stats_fetch_begin(&ring->syncp);
> + bytes = ring->stats.bytes;
> + packets = ring->stats.packets;
> + alloc_rx_page_failed =
> + ring->rx_stats.alloc_rx_page_failed;
> + alloc_rx_buff_failed =
> + ring->rx_stats.alloc_rx_buff_failed;
> + csum_err = ring->rx_stats.csum_err;
> + } while (u64_stats_fetch_retry(&ring->syncp, start));
> + }
> +
> + stats->bytes = bytes;
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:9772:6: warning: variable 'bytes' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
--
pw-not: cr
next prev parent reply other threads:[~2026-08-17 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 14:14 [PATCH net-next v5] ixgbe: implement get_queue_stats_rx Kshitiz Bartariya
2026-08-14 14:14 ` [Intel-wired-lan] " Kshitiz Bartariya via Intel-wired-lan
2026-08-17 23:43 ` Jakub Kicinski [this message]
2026-08-17 23:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817164308.5bf8bc87@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kshitiz.bartariya@zohomail.in \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.