From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Li Zhijian <lizhijian@fujitsu.com>,
Samuel Zhang <guoqing.zhang@amd.com>,
Fabiano Rosas <farosas@suse.de>,
peterx@redhat.com, Jack Wang <jinpu.wang@ionos.com>,
Juraj Marcin <jmarcin@redhat.com>,
Yanfei Xu <yanfei.xu@bytedance.com>
Subject: [PATCH 06/10] migration/rdma: Drop RDMARegister.key.chunk
Date: Mon, 17 Aug 2026 16:24:20 -0400 [thread overview]
Message-ID: <20260817202424.2901438-7-peterx@redhat.com> (raw)
In-Reply-To: <20260817202424.2901438-1-peterx@redhat.com>
Not used anymore.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/rdma.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index c06395a51a..f64bcee418 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -415,10 +415,7 @@ static void network_to_control(RDMAControlHeader *control)
* the actual RDMA operation.
*/
typedef struct QEMU_PACKED {
- union QEMU_PACKED {
- uint64_t current_addr; /* offset into the ram_addr_t space */
- uint64_t chunk; /* chunk to lookup if unregistering */
- } key;
+ uint64_t current_addr; /* offset into the ram_addr_t space */
uint32_t current_index; /* which ramblock the chunk belongs to */
uint32_t padding;
uint64_t chunks; /* how many sequential chunks to register */
@@ -443,16 +440,16 @@ static void register_to_network(RDMAContext *rdma, RDMARegister *reg)
* current_addr as passed in is an address in the local ram_addr_t
* space, we need to translate this for the destination
*/
- reg->key.current_addr -= local_block->offset;
- reg->key.current_addr += rdma->dest_blocks[reg->current_index].offset;
- reg->key.current_addr = htonll(reg->key.current_addr);
+ reg->current_addr -= local_block->offset;
+ reg->current_addr += rdma->dest_blocks[reg->current_index].offset;
+ reg->current_addr = htonll(reg->current_addr);
reg->current_index = htonl(reg->current_index);
reg->chunks = htonll(reg->chunks);
}
static void network_to_register(RDMARegister *reg)
{
- reg->key.current_addr = ntohll(reg->key.current_addr);
+ reg->current_addr = ntohll(reg->current_addr);
reg->current_index = ntohl(reg->current_index);
reg->chunks = ntohll(reg->chunks);
}
@@ -1833,7 +1830,7 @@ retry:
* Otherwise, tell other side to register.
*/
reg.current_index = current_index;
- reg.key.current_addr = current_addr;
+ reg.current_addr = current_addr;
reg.chunks = chunks;
trace_rdma_write_one_sendreg(chunk, sge.length, current_index,
@@ -3375,7 +3372,7 @@ int rdma_registration_handle(QEMUFile *f)
reg_result = &results[count];
trace_rdma_registration_handle_register_loop(count,
- reg->current_index, reg->key.current_addr, reg->chunks);
+ reg->current_index, reg->current_addr, reg->chunks);
if (reg->current_index >= rdma->local_ram_blocks.nb_blocks) {
error_report("rdma: 'register' bad block index %u (vs %d)",
@@ -3384,15 +3381,15 @@ int rdma_registration_handle(QEMUFile *f)
goto err;
}
block = &(rdma->local_ram_blocks.block[reg->current_index]);
- if (block->offset > reg->key.current_addr) {
+ if (block->offset > reg->current_addr) {
error_report("rdma: bad register address for block %s"
" offset: %" PRIx64 " current_addr: %" PRIx64,
block->block_name, block->offset,
- reg->key.current_addr);
+ reg->current_addr);
goto err;
}
host_addr = (block->local_host_addr +
- (reg->key.current_addr - block->offset));
+ (reg->current_addr - block->offset));
chunk = ram_chunk_index(block->local_host_addr,
(uint8_t *) host_addr);
chunk_start = ram_chunk_start(block, chunk);
--
2.54.0
next prev parent reply other threads:[~2026-08-17 20:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 20:24 [PATCH 00/10] migration/rdma: Fixes or drops Peter Xu
2026-08-17 20:24 ` [PATCH 01/10] migration/rdma: Introduce RDMA_CONTROL_NUM Peter Xu
2026-08-19 10:35 ` Jinpu Wang
2026-08-17 20:24 ` [PATCH 02/10] migration/rdma: Remove unregister code Peter Xu
2026-08-18 11:57 ` Yanfei Xu
2026-08-18 13:01 ` Peter Xu
2026-08-18 13:57 ` Yanfei Xu
2026-08-18 14:43 ` Peter Xu
2026-08-19 3:55 ` Yanfei Xu
2026-08-19 10:52 ` Jinpu Wang
2026-08-19 12:01 ` Jinpu Wang
2026-08-19 12:47 ` Peter Xu
2026-08-19 13:20 ` Jinpu Wang
2026-08-17 20:24 ` [PATCH 03/10] migration/rdma: Stick with rdma_ prefix for all tracepoints Peter Xu
2026-08-19 11:39 ` Jinpu Wang
2026-08-17 20:24 ` [PATCH 04/10] migration/rdma: Drop RDMALocalBlock.is_ram_block Peter Xu
2026-08-19 12:43 ` Jinpu Wang
2026-08-19 14:49 ` Peter Xu
2026-08-17 20:24 ` [PATCH 05/10] migration/rdma: Drop RDMALocalBlock.unregister_bitmap Peter Xu
2026-08-19 12:44 ` Jinpu Wang
2026-08-17 20:24 ` Peter Xu [this message]
2026-08-19 12:48 ` [PATCH 06/10] migration/rdma: Drop RDMARegister.key.chunk Jinpu Wang
2026-08-17 20:24 ` [PATCH 07/10] migration/rdma: Sanity check RDMA_CONTROL_REGISTER_REQUEST on buflen Peter Xu
2026-08-19 12:52 ` Jinpu Wang
2026-08-17 20:24 ` [PATCH 08/10] migration/rdma: Sanity check RDMA_CONTROL_REGISTER_REQUEST chunks Peter Xu
2026-08-19 13:00 ` Jinpu Wang
2026-08-17 20:24 ` [PATCH 09/10] migration/rdma: Sanity check upper bound of register MR address Peter Xu
2026-08-19 13:09 ` Jinpu Wang
2026-08-17 20:24 ` [PATCH 10/10] migration/rdma: Sanity check compress request ranges Peter Xu
2026-08-19 13:10 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817202424.2901438-7-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=guoqing.zhang@amd.com \
--cc=jinpu.wang@ionos.com \
--cc=jmarcin@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=yanfei.xu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.