From: Ziran Zhang <zhangcoder@yeah.net>
To: Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Kuniyuki Iwashima <kuniyu@google.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Ziran Zhang <zhangcoder@yeah.net>
Subject: [PATCH net-next] tcp: fix mdev comment in tcp_rtt_estimator()
Date: Tue, 18 Aug 2026 16:51:53 +0800 [thread overview]
Message-ID: <20260818085153.18509-1-zhangcoder@yeah.net> (raw)
The old comment "mdev = 3/4 mdev + 1/4 new" only describes the
common case. However, when RTT drops sharply, the code applies
a finer gain of 1/32 instead of 1/4, resulting in:
mdev = 31/32 mdev + 1/32 * new.
Express both cases with a unified formula using variable
gain g.
Signed-off-by: Ziran Zhang <zhangcoder@yeah.net>
---
net/ipv4/tcp_input.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 0f60a1dbf..2c9feb181 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1108,7 +1108,10 @@ static void tcp_rtt_estimator(struct sock *sk, long mrtt_us)
} else {
m -= (tp->mdev_us >> 2); /* similar update on mdev */
}
- tp->mdev_us += m; /* mdev = 3/4 mdev + 1/4 new */
+ tp->mdev_us += m; /*
+ * mdev = (1-g)*mdev + g*new, g=1/4 normally,
+ * g=1/32 on sharp RTT drop
+ */
if (tp->mdev_us > tp->mdev_max_us) {
tp->mdev_max_us = tp->mdev_us;
if (tp->mdev_max_us > tp->rttvar_us)
--
2.51.0
next reply other threads:[~2026-08-18 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 8:51 Ziran Zhang [this message]
2026-08-18 15:13 ` [PATCH net-next] tcp: fix mdev comment in tcp_rtt_estimator() Jakub Kicinski
2026-08-18 15:42 ` Ziran Zhang
2026-08-18 15:53 ` Jakub Kicinski
2026-08-18 16:03 ` Ziran Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818085153.18509-1-zhangcoder@yeah.net \
--to=zhangcoder@yeah.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.