All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ziran Zhang <zhangcoder@yeah.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
	Neal Cardwell <ncardwell@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	Simon Horman <horms@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Ziran Zhang <zhangcoder@yeah.net>
Subject: Re: [PATCH net-next] tcp: fix mdev comment in tcp_rtt_estimator()
Date: Wed, 19 Aug 2026 00:03:23 +0800	[thread overview]
Message-ID: <20260818160323.6727-1-zhangcoder@yeah.net> (raw)
In-Reply-To: <20260818085354.34325d0f@kernel.org>

On Tue, 18 Aug 2026 08:53:54 -0700, Jakub Kicinski wrote:
> TBH I'm not sure this patch is worth the review overhead in the first
> place.

Hi Jakub,

Thanks for your feedback.

I understand the concern about review overhead. The reason I think this
patch is worthwhile is that the current comment has been misleading for
years. It only describes the common case but omits the sharp RTT drop
case, which can confuse developers (especially newbies) trying to
understand the RTO calculation logic.

If you still think this fix is not worth a standalone patch, I'm happy
to follow your suggestion on how to best get it in.

Thanks,
Ziran Zhang


      reply	other threads:[~2026-08-18 16:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  8:51 [PATCH net-next] tcp: fix mdev comment in tcp_rtt_estimator() Ziran Zhang
2026-08-18 15:13 ` Jakub Kicinski
2026-08-18 15:42   ` Ziran Zhang
2026-08-18 15:53     ` Jakub Kicinski
2026-08-18 16:03       ` Ziran Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818160323.6727-1-zhangcoder@yeah.net \
    --to=zhangcoder@yeah.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.