Re: [PATCH RFC 2/4] dt-bindings: phy: ti,tcan104x-can: Document Microchip MCP2542 - sashiko-bot

From: sashiko-bot@kernel.org
To: "Stefan Wahren" <wahrenst@gmx.net>
Cc: "Oliver Hartkopp" <socketcan@hartkopp.net>,
	"Vincent Mailhol" <mailhol@kernel.org>,
	Frank.Li@kernel.org, robh@kernel.org, vkoul@kernel.org,
	olteanv@gmail.com, devicetree@vger.kernel.org,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	linux-can@vger.kernel.org, neil.armstrong@linaro.org,
	imx@lists.linux.dev, linux-phy@lists.infradead.org,
	"Marc Kleine-Budde" <mkl@pengutronix.de>,
	conor+dt@kernel.org
Subject: Re: [PATCH RFC 2/4] dt-bindings: phy: ti,tcan104x-can: Document Microchip MCP2542
Date: Tue, 18 Aug 2026 09:24:02 +0000	[thread overview]
Message-ID: <20260818092403.66D591F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818091701.6441-3-wahrenst@gmx.net>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The new compatible string 'microchip,mcp2542' is added as a standalone enum item in the binding but lacks corresponding support in the CAN transceiver PHY driver.
--

--- Patch [2]: [PATCH RFC 2/4] dt-bindings: phy: ti,tcan104x-can: Document Microchip MCP2542 ---
commit 43adb87775584a977c1d440864b9e805fba31d0e
Author: Stefan Wahren <wahrenst@gmx.net>

dt-bindings: phy: ti,tcan104x-can: Document Microchip MCP2542

The Microchip MCP2542 High-speed CAN transceiver with Sleep mode is a
pin-compatible alternative for the TI TCAN1042.

> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -24,6 +24,7 @@ properties:
>            - const: ti,tcan1046
>            - const: nxp,tja1048
>        - enum:
> +          - microchip,mcp2542

[Severity: High]
Since the compatible string is added as a standalone enum item, a device tree
node will not have a fallback string. Looking at the CAN transceiver PHY driver
in drivers/phy/phy-can-transceiver.c, the match table lacks this new string:

static const struct of_device_id can_transceiver_phy_ids[] = {
	{
		.compatible = "ti,tcan1042",
		.data = &tcan1042_drvdata
	},

Does this cause the PHY driver to fail to probe for the new device? If this is
a pin-compatible alternative for ti,tcan1042, should the binding require a
fallback compatible string so the existing driver can match it, or does the
driver need to be updated to support the standalone string?

>            - ti,tcan1042
>            - ti,tcan1043

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818091701.6441-1-wahrenst@gmx.net?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy