* [linux-next:master 11989/15435] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn60/dcn60_clk_mgr.c:1626 dcn60_clk_mgr_construct() warn: inconsistent indenting
@ 2026-08-18 1:32 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-08-18 1:32 UTC (permalink / raw)
To: Aurabindo Pillai; +Cc: oe-kbuild-all, Alex Deucher, Roman Li, Ivan Lipski
Hi Aurabindo,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4477a78374a57c3809b172ad30cceabda48c47c6
commit: 992694ad28584188725751f695a85661e8e3797a [11989/15435] drm/amd/display: Enable DCN6 sources compilation
config: x86_64-randconfig-161-20260810 (https://download.01.org/0day-ci/archive/20260818/202608180940.YUYrwhgV-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608180940.YUYrwhgV-lkp@intel.com/
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn60/dcn60_clk_mgr.c:1626 dcn60_clk_mgr_construct() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dce110/dce110_hwseq.c:3493 dce110_enable_tmds_link_output() warn: variable dereferenced before check 'link->link_enc' (see line 3483)
drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn50/dcn50_hwseq.c:424 dcn50_update_mpcc_sequence() warn: variable dereferenced before check 'pipe_ctx->plane_state' (see line 418)
drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn50/dcn50_hwseq.c:756 dcn50_init_hw() error: we previously assumed 'dc->res_pool->funcs->update_bw_bounding_box' could be null (see line 752)
drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn401/dcn401_hwseq.c:352 dcn401_init_hw() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/hubbub/dcn60/dcn60_hubbub.c:1592 hubbub60_perfmon_get_in_order_bandwidth_mbps() warn: variable dereferenced before check 'duration_ns' (see line 1576)
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2_0/dml21/src/dml2_core/dml2_core_dcn6_calcs_dchub.c:146 compute_pre_rec_first_hdl() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2_0/dml21/src/dml2_core/dml2_core_dcn6_calcs_dchub.c:298 calculate_alt_copy_time_us() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2_0/dml21/src/dml2_core/dml2_core_dcn6_calcs_dchub.c:716 dcn6_rq_dlg_get_dlg_reg() error: testing array offset 'l->plane_idx' after use.
drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn60/dcn60_resource.c:963 dcn60_program_mcache_pipe_config() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn60/dcn60_resource.c:1045 dcn60_i2c_hw_create() warn: curly braces intended?
drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn60/dcn60_resource.c:1048 dcn60_i2c_hw_create() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn60/dcn60_resource.c:1144 dcn60_hubp_create() warn: curly braces intended?
drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn60/dcn60_resource.c:1149 dcn60_hubp_create() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn60/dcn60_resource.c:1977 dcn60_resource_construct() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2_0/dml21/src/dml2_core/dml2_core_dcn5_calcs_dchub.c:917 dcn5_calculate_swath_and_det_configuration() warn: variable dereferenced before check 'p->UnboundedRequestEnabled' (see line 773)
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:1012 hwss_build_post_unlock_full_sequence() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2_0/dml21/src/dml2_core/dml2_core_dcn5_funcs_mode_support.c:647 dcn5_ms_calculate_odm_mode_per_plane() warn: inconsistent indenting
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dce110/dce110_hwseq.c:1250 dce110_disable_stream() warn: if statement not indented
drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dce110/dce110_hwseq.c:3498 dce110_enable_tmds_link_output() warn: variable dereferenced before check 'link->link_enc' (see line 3483)
drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn401/dcn401_hwseq.c:2017 dcn401_wait_for_det_buffer_update_under_otg_master() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2_0/dml21/src/dml2_core/dml2_core_dcn6_calcs_dchub.c:152 compute_pre_rec_first_hdl() warn: inconsistent indenting
vim +1626 drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn60/dcn60_clk_mgr.c
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1592
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1593 struct clk_mgr_internal *dcn60_clk_mgr_construct(
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1594 struct dc_context *ctx,
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1595 struct dccg *dccg)
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1596 {
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1597 struct clk_log_info log_info = {0};
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1598 struct dcn60_clk_mgr *clk_mgr60 = kzalloc(sizeof(struct dcn60_clk_mgr), GFP_KERNEL);
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1599 struct clk_mgr_internal *clk_mgr;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1600
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1601 if (!clk_mgr60)
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1602 return NULL;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1603
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1604 clk_mgr = &clk_mgr60->base;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1605 clk_mgr->base.ctx = ctx;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1606 clk_mgr->base.funcs = &dcn60_funcs;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1607 clk_mgr->regs = &clk_mgr_regs_dcn60;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1608 clk_mgr->clk_mgr_shift = &clk_mgr_shift_dcn60;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1609 clk_mgr->clk_mgr_mask = &clk_mgr_mask_dcn60;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1610
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1611 clk_mgr->dccg = dccg;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1612 clk_mgr->dfs_bypass_disp_clk = 0;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1613
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1614 clk_mgr->dprefclk_ss_percentage = 0;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1615 clk_mgr->dprefclk_ss_divider = 1000;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1616 clk_mgr->ss_on_dprefclk = false;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1617 clk_mgr->dfs_ref_freq_khz = 100000;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1618
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1619 /* Changed from DCN3.2_clock_frequency doc to match
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1620 * dcn60_dump_clk_registers from 4 * dentist_vco_freq_khz /
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1621 * dprefclk DID divider
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1622 */
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1623 clk_mgr->base.dprefclk_khz = 720000;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1624
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1625 /* integer part is now VCO frequency in kHz */
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 @1626 clk_mgr->base.dentist_vco_freq_khz = dcn60_get_vco_frequency_from_reg(clk_mgr);
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1627
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1628 /* in case we don't get a value from the register, use default */
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1629 if (clk_mgr->base.dentist_vco_freq_khz == 0)
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1630 clk_mgr->base.dentist_vco_freq_khz = 4500000;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1631
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1632 dcn60_dump_clk_registers(&clk_mgr->base.boot_snapshot, &clk_mgr->base, &log_info);
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1633
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1634 if (ctx->dc->debug.disable_dtb_ref_clk_switch &&
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1635 clk_mgr->base.clks.ref_dtbclk_khz != clk_mgr->base.boot_snapshot.dtbclk) {
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1636 clk_mgr->base.clks.ref_dtbclk_khz = clk_mgr->base.boot_snapshot.dtbclk;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1637 }
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1638
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1639 if (clk_mgr->base.boot_snapshot.dprefclk != 0)
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1640 clk_mgr->base.dprefclk_khz = clk_mgr->base.boot_snapshot.dprefclk;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1641 dcn60_clock_read_ss_info(clk_mgr);
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1642
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1643 clk_mgr->dfs_bypass_enabled = false;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1644
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1645 clk_mgr->smu_present = false;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1646
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1647 clk_mgr->base.bw_params = kzalloc(sizeof(*clk_mgr->base.bw_params), GFP_KERNEL);
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1648 if (!clk_mgr->base.bw_params)
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1649 goto fail;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1650
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1651 clk_mgr->dal_init_table = dm_helpers_allocate_gpu_mem(clk_mgr->base.ctx,
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1652 DC_MEM_ALLOC_TYPE_GART, sizeof(DalInitTable_t),
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1653 &clk_mgr->dal_init_table_addr);
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1654 if (!clk_mgr->dal_init_table)
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1655 goto fail;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1656
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1657 return &clk_mgr60->base;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1658
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1659 fail:
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1660 BREAK_TO_DEBUGGER();
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1661 dcn60_clk_mgr_destroy(clk_mgr);
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1662 kfree(clk_mgr60);
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1663 return NULL;
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1664 }
7f7d7ea1fa5151 Aurabindo Pillai 2026-07-22 1665
:::::: The code at line 1626 was first introduced by commit
:::::: 7f7d7ea1fa515157162d0d21245925551ed103a1 drm/amd/display: Add new sources for DCN6
:::::: TO: Aurabindo Pillai <aurabindo.pillai@amd.com>
:::::: CC: Alex Deucher <alexander.deucher@amd.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-18 1:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-18 1:32 [linux-next:master 11989/15435] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn60/dcn60_clk_mgr.c:1626 dcn60_clk_mgr_construct() warn: inconsistent indenting kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.