Re: [PATCH v2 4/7] dt-bindings: usb: ti,musb-am33xx: Convert to DT schema - sashiko-bot

From: sashiko-bot@kernel.org
To: "Bhargav Joshi" <j.bhargav.u@gmail.com>
Cc: neil.armstrong@linaro.org, vkoul@kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmaengine@vger.kernel.org,
	olteanv@gmail.com, devicetree@vger.kernel.org,
	Frank.Li@kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v2 4/7] dt-bindings: usb: ti,musb-am33xx: Convert to DT schema
Date: Tue, 18 Aug 2026 14:39:56 +0000	[thread overview]
Message-ID: <20260818143957.62EDD1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818-ti-am33-usb-v2-4-66fd44d66824@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing type reference for `mentor,ram-bits` vendor property in DT schema.
--

--- Patch [4]: [PATCH v2 4/7] dt-bindings: usb: ti,musb-am33xx: Convert to DT schema ---
commit cf3529cd6795cb99eba5fc624b9972e24548b4e8
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: usb: ti,musb-am33xx: Convert to DT schema

This commit converts the TI AM33xx MUSB text bindings to DT schema. It
also introduces several updates during the conversion, such as allowing an
optional vbus interrupt and adding interface-type and phy-names properties
natively used by the dm816x hardware.

> diff --git a/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml b/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml
> new file mode 100644
> index 0000000000000..cc01edc75d11e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml
[ ... ]
> +  mentor,num-eps:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Specifies the number of endpoints.
> +    const: 16
> +
> +  mentor,ram-bits:
> +    description: Specifies the ram address size.
> +    const: 12

[Severity: Low]
Will this cause schema validation to fail during make dt_binding_check?

Without a type reference, the array <12> in device trees might be validated
as a matrix against const: 12 instead of a scalar integer, causing a type
mismatch error. 

Should this include a $ref to /schemas/types.yaml#/definitions/uint32
similar to mentor,num-eps?

> +
> +  mentor,power:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Controller supply capacity (in mA) when operating in host mode.
> +    const: 500

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818-ti-am33-usb-v2-0-66fd44d66824@gmail.com?part=4

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy