* [PATCH v2 0/2] chipid: samsung: exynos-chipid: Add Exynos5515 ChipID
@ 2026-08-18 15:05 ` Aiden Isik
0 siblings, 0 replies; 7+ messages in thread
From: Aiden Isik @ 2026-08-18 15:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Aiden Isik
Hi there,
This patchset adds support for the Exynos5515 SoC's ChipID to the
ChipID driver, and documents the samsung,exynos5515-chipid compatible.
Signed-off-by: Aiden Isik <aidenisik@member.fsf.org>
---
Changes in v2:
- Correct capitalisation of "Exynos5515" in commit messages
- Reword documentation commit message
- Link to v1: https://patch.msgid.link/20260817-for-next-lucky7-chipid-v1-0-eb2908705c0d@member.fsf.org
---
Aiden Isik (2):
dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible
soc: samsung: exynos-chipid: Add Exynos5515 SoC support
Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
drivers/soc/samsung/exynos-chipid.c | 1 +
2 files changed, 2 insertions(+)
---
base-commit: acde40ba506aae78633e080b5704d33cf4bc13c6
change-id: 20260815-for-next-lucky7-chipid-ecce496c86b9
Best regards,
--
Aiden Isik <aidenisik@member.fsf.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible
2026-08-18 15:05 ` Aiden Isik
@ 2026-08-18 15:05 ` Aiden Isik
-1 siblings, 0 replies; 7+ messages in thread
From: Aiden Isik via B4 Relay @ 2026-08-18 15:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Aiden Isik
From: Aiden Isik <aidenisik@member.fsf.org>
Add "samsung,exynos5515-chipid" compatible string to binding document,
which is fully compatible with "samsung,exynos850-chipid".
Signed-off-by: Aiden Isik <aidenisik@member.fsf.org>
---
Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
index b9cdfe52b62f..619faf33214b 100644
--- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
+++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
@@ -25,6 +25,7 @@ properties:
- items:
- enum:
- samsung,exynos2200-chipid
+ - samsung,exynos5515-chipid
- samsung,exynos7885-chipid
- samsung,exynos8895-chipid
- samsung,exynos9610-chipid
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible
@ 2026-08-18 15:05 ` Aiden Isik
0 siblings, 0 replies; 7+ messages in thread
From: Aiden Isik @ 2026-08-18 15:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Aiden Isik
Add "samsung,exynos5515-chipid" compatible string to binding document,
which is fully compatible with "samsung,exynos850-chipid".
Signed-off-by: Aiden Isik <aidenisik@member.fsf.org>
---
Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
index b9cdfe52b62f..619faf33214b 100644
--- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
+++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
@@ -25,6 +25,7 @@ properties:
- items:
- enum:
- samsung,exynos2200-chipid
+ - samsung,exynos5515-chipid
- samsung,exynos7885-chipid
- samsung,exynos8895-chipid
- samsung,exynos9610-chipid
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible
2026-08-18 15:05 ` Aiden Isik
(?)
@ 2026-08-18 15:13 ` sashiko-bot
-1 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-08-18 15:13 UTC (permalink / raw)
To: Aiden Isik; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch adds the `samsung,exynos5515-chipid` compatible string with a fallback to `samsung,exynos850-chipid`, but omits the necessary driver update to support the new SoC. The `exynos-chipid` driver enforces a strict hardware whitelist based on the product ID and will return `-ENODEV` during probe when it encounters the unknown Exynos 5515 ID, rendering the fallback useless.
--
--- Patch [1]: [PATCH v2 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible ---
commit c6d7dc985bd68c7bd5ad1ca061556d7ae1c7ee31
Author: Aiden Isik <aidenisik@member.fsf.org>
Subject: dt-bindings: hwinfo: samsung,exynos-chipid: Add Exynos5515 compatible
This commit adds the samsung,exynos5515-chipid compatible string to the
exynos-chipid device tree bindings documentation.
> diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> index b9cdfe52b62ff..619faf33214bd 100644
> --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> @@ -25,6 +25,7 @@ properties:
> - items:
> - enum:
> - samsung,exynos2200-chipid
> + - samsung,exynos5515-chipid
[Severity: Medium]
Will this compatible string actually allow the driver to probe on Exynos 5515
hardware?
Even with a fallback to samsung,exynos850-chipid, the exynos-chipid driver
enforces a strict hardware whitelist based on the product ID:
drivers/soc/samsung/exynos-chipid.c:exynos_chipid_probe() {
...
soc_dev_attr->soc_id = exynos_product_id_to_name(soc_info.product_id);
if (!soc_dev_attr->soc_id)
return dev_err_probe(dev, -ENODEV, "Unknown SoC\n");
...
}
Does this require a corresponding driver update to add the Exynos 5515 product
ID to the whitelist so the probe does not fail with -ENODEV?
> - samsung,exynos7885-chipid
> - samsung,exynos8895-chipid
> - samsung,exynos9610-chipid
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260818-for-next-lucky7-chipid-v2-0-28ae49f5c349@member.fsf.org?part=1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] soc: samsung: exynos-chipid: Add Exynos5515 SoC support
2026-08-18 15:05 ` Aiden Isik
@ 2026-08-18 15:05 ` Aiden Isik
-1 siblings, 0 replies; 7+ messages in thread
From: Aiden Isik via B4 Relay @ 2026-08-18 15:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Aiden Isik
From: Aiden Isik <aidenisik@member.fsf.org>
Add Exynos5515 information to the soc_ids table.
The ChipID for Exynos5515 is "0xE5515000".
Signed-off-by: Aiden Isik <aidenisik@member.fsf.org>
---
drivers/soc/samsung/exynos-chipid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
index 6ef9751e2509..506a0bcdfe30 100644
--- a/drivers/soc/samsung/exynos-chipid.c
+++ b/drivers/soc/samsung/exynos-chipid.c
@@ -64,6 +64,7 @@ static const struct exynos_soc_id {
{ "EXYNOS8890", 0xE8890000 },
/* Compatible with: samsung,exynos850-chipid */
{ "EXYNOS2200", 0xE9925000 },
+ { "EXYNOS5515", 0xE5515000 },
{ "EXYNOS7885", 0xE7885000 },
{ "EXYNOS850", 0xE3830000 },
{ "EXYNOS8895", 0xE8895000 },
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 2/2] soc: samsung: exynos-chipid: Add Exynos5515 SoC support
@ 2026-08-18 15:05 ` Aiden Isik
0 siblings, 0 replies; 7+ messages in thread
From: Aiden Isik @ 2026-08-18 15:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Aiden Isik
Add Exynos5515 information to the soc_ids table.
The ChipID for Exynos5515 is "0xE5515000".
Signed-off-by: Aiden Isik <aidenisik@member.fsf.org>
---
drivers/soc/samsung/exynos-chipid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
index 6ef9751e2509..506a0bcdfe30 100644
--- a/drivers/soc/samsung/exynos-chipid.c
+++ b/drivers/soc/samsung/exynos-chipid.c
@@ -64,6 +64,7 @@ static const struct exynos_soc_id {
{ "EXYNOS8890", 0xE8890000 },
/* Compatible with: samsung,exynos850-chipid */
{ "EXYNOS2200", 0xE9925000 },
+ { "EXYNOS5515", 0xE5515000 },
{ "EXYNOS7885", 0xE7885000 },
{ "EXYNOS850", 0xE3830000 },
{ "EXYNOS8895", 0xE8895000 },
--
2.54.0
^ permalink raw reply related [flat|nested] 7+ messages in thread