From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Stefan Popa <stefan.popa@analog.com>,
linux-iio@vger.kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, andy@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com,
siratul.islam@linux.dev, u.kleine-koenig@baylibre.com,
linux@roeck-us.net, joshua.crofts1@gmail.com,
ciprian.hegbeli@analog.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/2] iio: adc: add MAX40080 current-sense amplifier driver
Date: Tue, 18 Aug 2026 17:19:53 +0100 [thread overview]
Message-ID: <20260818171953.4dd76b83@jic23-huawei> (raw)
In-Reply-To: <aoR94S2qknBVQrT3@ashevche-desk.local>
> ...
>
> > +static const struct iio_chan_spec max40080_channels[] = {
> > + {
> > + .type = IIO_CURRENT,
> > + .indexed = 1,
>
> > + .channel = 0,
>
> No need
True, but I'd keep it because it is paired with indexed and looking
for both together is common.
>
> > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> > + BIT(IIO_CHAN_INFO_SCALE),
> > + .info_mask_separate_available = BIT(IIO_CHAN_INFO_SCALE),
> > + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
> > + .info_mask_shared_by_all_available =
> > + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
> > + },
> > + {
> > + .type = IIO_VOLTAGE,
> > + .indexed = 1,
>
> > + .channel = 0,
>
> Same, it's default.
>
> > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> > + BIT(IIO_CHAN_INFO_SCALE),
> > + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
> > + .info_mask_shared_by_all_available =
> > + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
> > + },
> > +};
next prev parent reply other threads:[~2026-08-18 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 14:29 [PATCH v7 0/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-08-18 14:29 ` [PATCH v7 1/2] dt-bindings: iio: adc: add adi,max40080 Stefan Popa
2026-08-18 14:29 ` [PATCH v7 2/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-08-18 14:39 ` sashiko-bot
2026-08-18 15:44 ` Andy Shevchenko
2026-08-18 16:19 ` Jonathan Cameron [this message]
2026-08-19 6:51 ` Andy Shevchenko
2026-08-18 16:38 ` Jonathan Cameron
2026-08-19 8:00 ` Siratul Islam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818171953.4dd76b83@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=ciprian.hegbeli@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=siratul.islam@linux.dev \
--cc=stefan.popa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.