All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Siratul Islam" <siratul.islam@linux.dev>
To: "Stefan Popa" <stefan.popa@analog.com>, linux-iio@vger.kernel.org
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	andy@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	u.kleine-koenig@baylibre.com, linux@roeck-us.net,
	joshua.crofts1@gmail.com, ciprian.hegbeli@analog.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Stefan Popa" <stefan.popa@analog.com>
Subject: Re: [PATCH v7 2/2] iio: adc: add MAX40080 current-sense amplifier driver
Date: Wed, 19 Aug 2026 08:00:18 +0000	[thread overview]
Message-ID: <38ad21d4eaf5c7071aaf45d2ce650daffe16ef6b@linux.dev> (raw)
In-Reply-To: <20260818142928.8244-3-stefan.popa@analog.com>

August 18, 2026 at 8:29 PM, "Stefan Popa" <stefan.popa@analog.com> wrote:


> 
> The MAX40080 is a bidirectional current-sense amplifier with an
> integrated 12-bit ADC and an I2C/SMBus interface. It measures the
> voltage across an external shunt resistor and the input bus voltage,
> storing the results in an internal FIFO.
> 
> Add a direct-mode IIO driver exposing the current and voltage channels
> with raw, scale and hardware-gain attributes, a configurable
> oversampling (digital averaging) ratio, and PEC-protected register
> access. The current scale is derived from the shunt resistor value
> described in the device tree.
> 
> The driver operates in single-measurement mode: each raw read triggers
> an on-demand conversion via SMBus Quick Command and returns a matched
> current/voltage pair. This avoids the latency and complexity of the
> continuous FIFO mode while ensuring each read reflects the current
> state. The two selectable current-sense ranges are exposed through
> scale/scale_available.
> 
> Continuous FIFO buffering, threshold events and the alert interrupt are
> intentionally left out of this initial submission and may be added
> later.
> 
> Co-developed-by: Ciprian Hegbeli <ciprian.hegbeli@analog.com>
> Signed-off-by: Ciprian Hegbeli <ciprian.hegbeli@analog.com>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> ---
>
Looks like my concerns have been addressed. Assuming you are going to send v8 with
fixes for Andy and Jonathan, feel free to add my tag.

Reviewed-by: Siratul Islam <siratul.islam@linux.dev>

      parent reply	other threads:[~2026-08-19  8:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 14:29 [PATCH v7 0/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-08-18 14:29 ` [PATCH v7 1/2] dt-bindings: iio: adc: add adi,max40080 Stefan Popa
2026-08-18 14:29 ` [PATCH v7 2/2] iio: adc: add MAX40080 current-sense amplifier driver Stefan Popa
2026-08-18 14:39   ` sashiko-bot
2026-08-18 15:44   ` Andy Shevchenko
2026-08-18 16:19     ` Jonathan Cameron
2026-08-19  6:51       ` Andy Shevchenko
2026-08-18 16:38   ` Jonathan Cameron
2026-08-19  8:00   ` Siratul Islam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38ad21d4eaf5c7071aaf45d2ce650daffe16ef6b@linux.dev \
    --to=siratul.islam@linux.dev \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=ciprian.hegbeli@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=stefan.popa@analog.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.