All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Cervesato <andrea.cervesato@suse.de>
To: Linux Test Project <ltp@lists.linux.it>
Subject: [LTP] [PATCH STAGING 08/16] fchroot05: test failfs root can not be referenced
Date: Wed, 19 Aug 2026 23:24:23 +0200	[thread overview]
Message-ID: <20260819-fchroot-v1-8-2dc2c3c3cf29@suse.com> (raw)
In-Reply-To: <20260819-fchroot-v1-0-2dc2c3c3cf29@suse.com>

From: Andrea Cervesato <andrea.cervesato@suse.com>

Verify that once fchroot() moved the root into failfs, the root
directory can not be opened anymore, not even with O_PATH, nor pinned
by following the /proc/self/root magic link, although readlink()
still names it as "failfs:/" since it does not follow the link.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 runtest/staging                               |  1 +
 testcases/kernel/syscalls/fchroot/.gitignore  |  1 +
 testcases/kernel/syscalls/fchroot/fchroot05.c | 75 +++++++++++++++++++++++++++
 3 files changed, 77 insertions(+)

diff --git a/runtest/staging b/runtest/staging
index 91dfdba08..49f51d637 100644
--- a/runtest/staging
+++ b/runtest/staging
@@ -4,3 +4,4 @@ fchroot01 fchroot01
 fchroot02 fchroot02
 fchroot03 fchroot03
 fchroot04 fchroot04
+fchroot05 fchroot05
diff --git a/testcases/kernel/syscalls/fchroot/.gitignore b/testcases/kernel/syscalls/fchroot/.gitignore
index 9270c1408..0697f10eb 100644
--- a/testcases/kernel/syscalls/fchroot/.gitignore
+++ b/testcases/kernel/syscalls/fchroot/.gitignore
@@ -2,3 +2,4 @@ fchroot01
 fchroot02
 fchroot03
 fchroot04
+fchroot05
diff --git a/testcases/kernel/syscalls/fchroot/fchroot05.c b/testcases/kernel/syscalls/fchroot/fchroot05.c
new file mode 100644
index 000000000..3046594ed
--- /dev/null
+++ b/testcases/kernel/syscalls/fchroot/fchroot05.c
@@ -0,0 +1,75 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2026 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
+ */
+
+/*\
+ * Test that the failfs root can not be referenced once it is the process
+ * root.
+ *
+ * After :manpage:`fchroot(2)` moved the root into failfs, the root
+ * directory can not be opened anymore, not even with O_PATH, because the
+ * walk lands on the failfs root as its terminal. The root also can not
+ * be pinned by following the /proc/self/root magic link into it, although
+ * :manpage:`readlink(2)` still names it as "failfs:/" since it does not
+ * follow the link.
+ *
+ * Root is required because entering failfs with the FD_FAILFS_ROOT
+ * sentinel requires CAP_SYS_CHROOT.
+ *
+ * /proc must be opened before entering failfs because every absolute path
+ * lookup fails once the root is unreachable. The test runs in a forked
+ * child so the root of the parent process is left untouched.
+ */
+
+#define _GNU_SOURCE
+#include <fcntl.h>
+#include <limits.h>
+#include <sys/stat.h>
+#include <unistd.h>
+#include "tst_test.h"
+#include "lapi/fcntl.h"
+#include "lapi/syscalls.h"
+
+static void run(void)
+{
+	if (!SAFE_FORK()) {
+		char buf[PATH_MAX];
+		struct stat st;
+		int procfd, len;
+
+		procfd = SAFE_OPEN("/proc", O_PATH | O_DIRECTORY);
+
+		TST_EXP_PASS(tst_syscall(__NR_fchroot, FD_FAILFS_ROOT, 0),
+			"fchroot() with the FD_FAILFS_ROOT sentinel");
+
+		TST_EXP_FAIL2(open("/", O_RDONLY | O_DIRECTORY), EOPNOTSUPP,
+			"open() of the failfs root");
+
+		TST_EXP_FAIL2(open("/", O_PATH), EOPNOTSUPP,
+			"O_PATH open() of the failfs root");
+
+		TST_EXP_FAIL2(openat(procfd, "self/root", O_PATH), EOPNOTSUPP,
+			"pin of the root via /proc/self/root");
+
+		TST_EXP_FAIL(fstatat(procfd, "self/root", &st, 0), EOPNOTSUPP,
+			"stat of the root via /proc/self/root");
+
+		len = readlinkat(procfd, "self/root", buf, sizeof(buf) - 1);
+		if (len < 0) {
+			tst_res(TFAIL | TTERRNO,
+				"readlinkat() of /proc/self/root");
+		} else {
+			buf[len] = '\0';
+			TST_EXP_EQ_STR(buf, "failfs:/");
+		}
+
+		exit(0);
+	}
+}
+
+static struct tst_test test = {
+	.test_all = run,
+	.needs_root = 1,
+	.forks_child = 1,
+};

-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-08-19 21:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 21:24 [LTP] [PATCH 00/16] fchroot: add fchroot() testing suite Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH 01/16] syscalls: add v7.3 syscall numbers Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH 02/16] syscalls: update outdated syscall entries Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH 03/16] lapi: fallback fchroot() parameters Andrea Cervesato
2026-08-19 22:27   ` [LTP] syscalls: add v7.3 syscall numbers linuxtestproject.agent
2026-08-20  6:03     ` Andrea Cervesato via ltp
2026-08-19 21:24 ` [LTP] [PATCH STAGING 04/16] fchroot01: test fchroot() with a directory fd Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 05/16] fchroot02: test fchroot() invalid arguments Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 06/16] fchroot03: test fchroot() permission checks Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 07/16] fchroot04: test fchroot() into failfs as root Andrea Cervesato
2026-08-19 21:24 ` Andrea Cervesato [this message]
2026-08-19 21:24 ` [LTP] [PATCH STAGING 09/16] fchroot06: test path walks under failfs root Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 10/16] fchroot07: test execve blocked by " Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 11/16] fchroot08: test failfs root fork inheritance Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 12/16] fchroot09: test setns escape from failfs root Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 13/16] fchroot10: test failfs entry without no_new_privs Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 14/16] fchroot11: test failfs entry with no_new_privs Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 15/16] fchroot12: test failfs entry with shared fs_struct Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 16/16] fchroot13: test failfs entry when chrooted Andrea Cervesato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819-fchroot-v1-8-2dc2c3c3cf29@suse.com \
    --to=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.