* [PATCH] sched: Remove unneeded function type cast in do_balance_callbacks()
@ 2026-08-19 8:01 Vladimir Zapolskiy
2026-08-19 8:07 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Zapolskiy @ 2026-08-19 8:01 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot
Cc: Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, K Prateek Nayak, linux-kernel
It's a trivial and non-functional change, the removed explicit function
type cast does not convert the function type of struct balance_callback
member (*func), and the cast can be removed.
Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index f5f7ff8c680a..63956d8c3db6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5126,7 +5126,7 @@ static void do_balance_callbacks(struct rq *rq, struct balance_callback *head)
lockdep_assert_rq_held(rq);
while (head) {
- func = (void (*)(struct rq *))head->func;
+ func = head->func;
next = head->next;
head->next = NULL;
head = next;
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] sched: Remove unneeded function type cast in do_balance_callbacks()
2026-08-19 8:01 [PATCH] sched: Remove unneeded function type cast in do_balance_callbacks() Vladimir Zapolskiy
@ 2026-08-19 8:07 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2026-08-19 8:07 UTC (permalink / raw)
To: Vladimir Zapolskiy
Cc: Ingo Molnar, Juri Lelli, Vincent Guittot, Dietmar Eggemann,
Steven Rostedt, Ben Segall, Mel Gorman, Valentin Schneider,
K Prateek Nayak, linux-kernel
On Wed, Aug 19, 2026 at 11:01:58AM +0300, Vladimir Zapolskiy wrote:
> It's a trivial and non-functional change, the removed explicit function
> type cast does not convert the function type of struct balance_callback
> member (*func), and the cast can be removed.
Right you are; I suspect this was once a struct callback_head. Ah yes,
see commit: 8e5bad7dccec ("sched: Introduce struct balance_callback to
avoid CFI mismatches").
> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> ---
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index f5f7ff8c680a..63956d8c3db6 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5126,7 +5126,7 @@ static void do_balance_callbacks(struct rq *rq, struct balance_callback *head)
> lockdep_assert_rq_held(rq);
>
> while (head) {
> - func = (void (*)(struct rq *))head->func;
> + func = head->func;
> next = head->next;
> head->next = NULL;
> head = next;
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-19 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-19 8:01 [PATCH] sched: Remove unneeded function type cast in do_balance_callbacks() Vladimir Zapolskiy
2026-08-19 8:07 ` Peter Zijlstra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.