From: sashiko-bot@kernel.org
To: "Luigi Rizzo" <lrizzo@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 7/7] PCI/MSI: re-enable conditional parent mask/unmask with sw moderation
Date: Wed, 19 Aug 2026 12:51:07 +0000 [thread overview]
Message-ID: <20260819125108.1036B1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260819124341.4185621-8-lrizzo@google.com>
> Recent commits removed masking of interrupts at the PCIe level when
> the masking is also done at the parent (e.g. on ARM with GIC). This
> optimization saves the PCIe write, and especially the expensive readback,
> but causes the device to still send MSI interrupts that are ignored.
>
> As a result, it very harmful on platforms (many, for multiple
> architectures) that are unable to deal with too many MSI interrupts, and
> defeats GSIM (CONFIG_IRQ_SW_MODERATION), which is esplicitely designed to
> address this problem, but depends on masking interrupts at the PCIe level.
>
> Revert to the old behavior when GSIM (CONFIG_IRQ_SW_MODERATION)
> is compiled in.
>
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260819124341.4185621-1-lrizzo@google.com?part=7
prev parent reply other threads:[~2026-08-19 12:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 12:43 [PATCH v5 0/7] Global Software Interrupt Moderation (GSIM) Luigi Rizzo
2026-08-19 12:43 ` [PATCH v5 1/7] genirq: Add flags for software interrupt moderation Luigi Rizzo
2026-08-19 12:50 ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 2/7] genirq: Add GSIM infrastructure Luigi Rizzo
2026-08-19 12:48 ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 3/7] genirq: Implement core GSIM moderation logic Luigi Rizzo
2026-08-19 12:52 ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 4/7] genirq: Integrate GSIM into interrupt flow Luigi Rizzo
2026-08-19 12:58 ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 5/7] genirq: Add GSIM user space configuration (procfs) Luigi Rizzo
2026-08-19 12:58 ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 6/7] genirq: Adaptive Global Software Interrupt Moderation (GSIM) Luigi Rizzo
2026-08-19 12:59 ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 7/7] PCI/MSI: re-enable conditional parent mask/unmask with sw moderation Luigi Rizzo
2026-08-19 12:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819125108.1036B1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lrizzo@google.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.