All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Luigi Rizzo" <lrizzo@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 6/7] genirq: Adaptive Global Software Interrupt Moderation (GSIM).
Date: Wed, 19 Aug 2026 12:59:13 +0000	[thread overview]
Message-ID: <20260819125913.D7CE41F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260819124341.4185621-7-lrizzo@google.com>

> GSIM helps keeping system load (as defined later) under control, but
> the use of a fixed moderation delay causes unnecessary latency when the
> system load is already low.
> 
> We focus on two types of system load related to interrupts:
> - total device interrupt rates. Some platforms show severe I/O
>   performance degradation with more than 1-2 Mintr/s across the entire
>   system. This affects especially server-class hardware with hundreds of
>   interrupt sources (NIC or SSD queues from many physical or virtualized
>   devices).
> - percentage of time spent in hardirq. This can become problematic in
>   presence of large numbers of interrupt sources hitting individual CPUs
>   (for instance, as a result of attempts to isolate application CPUs
>   from interrupt load).
> 
> [ ... ]
> hardirq_percent (delay_us = 200, target_intr_rate=0, iodepth 128)
> hardirq%	1	10	20	30	40	50	60	70
> KIOPS		13900	13800	13300	12100	10400	8600	7400	6500
> 
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260819124341.4185621-1-lrizzo@google.com?part=6


  reply	other threads:[~2026-08-19 12:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 12:43 [PATCH v5 0/7] Global Software Interrupt Moderation (GSIM) Luigi Rizzo
2026-08-19 12:43 ` [PATCH v5 1/7] genirq: Add flags for software interrupt moderation Luigi Rizzo
2026-08-19 12:50   ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 2/7] genirq: Add GSIM infrastructure Luigi Rizzo
2026-08-19 12:48   ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 3/7] genirq: Implement core GSIM moderation logic Luigi Rizzo
2026-08-19 12:52   ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 4/7] genirq: Integrate GSIM into interrupt flow Luigi Rizzo
2026-08-19 12:58   ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 5/7] genirq: Add GSIM user space configuration (procfs) Luigi Rizzo
2026-08-19 12:58   ` sashiko-bot
2026-08-19 12:43 ` [PATCH v5 6/7] genirq: Adaptive Global Software Interrupt Moderation (GSIM) Luigi Rizzo
2026-08-19 12:59   ` sashiko-bot [this message]
2026-08-19 12:43 ` [PATCH v5 7/7] PCI/MSI: re-enable conditional parent mask/unmask with sw moderation Luigi Rizzo
2026-08-19 12:51   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819125913.D7CE41F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lrizzo@google.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.