Re: [PATCH v3 3/4] arm64: dts: qcom: monaco-evk: Describe the PCIe M.2 Key E connector

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Node overrides are not sorted alphabetically.
--

--- Patch [3]: [PATCH v3 3/4] arm64: dts: qcom: monaco-evk: Describe the PCIe M.2 Key E connector ---
commit 208b6f2eef3b23e678fa76e3866767bc52da9a8e
Author: Wei Deng <wei.deng@oss.qualcomm.com>

arm64: dts: qcom: monaco-evk: Describe the PCIe M.2 Key E connector

The monaco EVK has a PCIe M.2 Mechanical Key E connector to connect
wireless connectivity cards over PCIe and UART interfaces. Hence,
describe the connector node and link it with the PCIe 0 Root Port and
UART2 nodes through graph port/endpoint.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 9d17ef7d2caf1..5930ddb3b4b18 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts

[ ... ]

> @@ -923,3 +971,11 @@ &usb_2_hsphy {
>  
>  	status = "okay";
>  };
> +
> +&uart2 {
> +	status = "okay";
> +};
> +
> +&uart2_ep {
> +	remote-endpoint = <&m2_e_uart_ep>;
> +};

[Severity: Low]
Are these node overrides out of alphabetical order?

They appear to be appended to the end of the file after &usb_2_hsphy, rather
than sorted alphabetically alongside the other node overrides.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260819-b4-monaco-evk-m2-v1-v3-0-988145ef65cd@oss.qualcomm.com?part=3