* [f2fs-dev] [PATCH] f2fs: fix to migrate all curseg types during free_segment_range
@ 2026-08-18 17:00 Daeho Jeong
2026-08-19 1:56 ` Chao Yu
0 siblings, 1 reply; 5+ messages in thread
From: Daeho Jeong @ 2026-08-18 17:00 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong
From: Daeho Jeong <daehojeong@google.com>
In free_segment_range(), the curseg evacuation loop only iterates up to
NR_CURSEG_PERSIST_TYPE (0..5), missing non-persistent in-memory curseg
types such as CURSEG_COLD_DATA_PINNED and CURSEG_ALL_DATA_ATGC.
Even though these in-memory curseg types are not saved in the on-disk
checkpoint header, they still occupy active physical segments at runtime.
If an active in-memory curseg happens to be allocated within the segment
range being truncated during filesystem shrink, failing to evacuate it
will cause subsequent writes to the curseg attempting out-of-bounds I/O
on the truncated storage range.
Fix this by expanding the curseg evacuation loop upper bound to
NR_CURSEG_TYPE to ensure all active curseg types are safely migrated
out of the target range.
Signed-off-by: Daeho Jeong <daehojeong@google.com>
Signed-off-by: Sunmin Jeong <s_min.jeong@samsung.com>
---
fs/f2fs/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index ffaa7ba76a1b..192b16ac02f8 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -2222,7 +2222,7 @@ static int free_segment_range(struct f2fs_sb_info *sbi,
mutex_unlock(&DIRTY_I(sbi)->seglist_lock);
/* Move out cursegs from the target range */
- for (type = CURSEG_HOT_DATA; type < NR_CURSEG_PERSIST_TYPE; type++) {
+ for (type = CURSEG_HOT_DATA; type < NR_CURSEG_TYPE; type++) {
err = f2fs_allocate_segment_for_resize(sbi, type, start, end);
if (err)
goto out;
--
2.55.0.691.gc56d675ccc-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: fix to migrate all curseg types during free_segment_range
2026-08-18 17:00 [f2fs-dev] " Daeho Jeong
@ 2026-08-19 1:56 ` Chao Yu
0 siblings, 0 replies; 5+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2026-08-19 1:56 UTC (permalink / raw)
To: Daeho Jeong, linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong
On 8/19/26 01:00, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> In free_segment_range(), the curseg evacuation loop only iterates up to
> NR_CURSEG_PERSIST_TYPE (0..5), missing non-persistent in-memory curseg
> types such as CURSEG_COLD_DATA_PINNED and CURSEG_ALL_DATA_ATGC.
>
> Even though these in-memory curseg types are not saved in the on-disk
> checkpoint header, they still occupy active physical segments at runtime.
> If an active in-memory curseg happens to be allocated within the segment
> range being truncated during filesystem shrink, failing to evacuate it
> will cause subsequent writes to the curseg attempting out-of-bounds I/O
> on the truncated storage range.
>
> Fix this by expanding the curseg evacuation loop upper bound to
> NR_CURSEG_TYPE to ensure all active curseg types are safely migrated
> out of the target range.
>
Need fixes and Cc stable line.
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> Signed-off-by: Sunmin Jeong <s_min.jeong@samsung.com>
> ---
> fs/f2fs/gc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index ffaa7ba76a1b..192b16ac02f8 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -2222,7 +2222,7 @@ static int free_segment_range(struct f2fs_sb_info *sbi,
> mutex_unlock(&DIRTY_I(sbi)->seglist_lock);
>
> /* Move out cursegs from the target range */
> - for (type = CURSEG_HOT_DATA; type < NR_CURSEG_PERSIST_TYPE; type++) {
> + for (type = CURSEG_HOT_DATA; type < NR_CURSEG_TYPE; type++) {
> err = f2fs_allocate_segment_for_resize(sbi, type, start, end);
> if (err)
> goto out;
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: fix to migrate all curseg types during free_segment_range
@ 2026-08-19 1:56 ` Chao Yu
0 siblings, 0 replies; 5+ messages in thread
From: Chao Yu @ 2026-08-19 1:56 UTC (permalink / raw)
To: Daeho Jeong, linux-kernel, linux-f2fs-devel, kernel-team
Cc: chao, Daeho Jeong
On 8/19/26 01:00, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> In free_segment_range(), the curseg evacuation loop only iterates up to
> NR_CURSEG_PERSIST_TYPE (0..5), missing non-persistent in-memory curseg
> types such as CURSEG_COLD_DATA_PINNED and CURSEG_ALL_DATA_ATGC.
>
> Even though these in-memory curseg types are not saved in the on-disk
> checkpoint header, they still occupy active physical segments at runtime.
> If an active in-memory curseg happens to be allocated within the segment
> range being truncated during filesystem shrink, failing to evacuate it
> will cause subsequent writes to the curseg attempting out-of-bounds I/O
> on the truncated storage range.
>
> Fix this by expanding the curseg evacuation loop upper bound to
> NR_CURSEG_TYPE to ensure all active curseg types are safely migrated
> out of the target range.
>
Need fixes and Cc stable line.
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> Signed-off-by: Sunmin Jeong <s_min.jeong@samsung.com>
> ---
> fs/f2fs/gc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index ffaa7ba76a1b..192b16ac02f8 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -2222,7 +2222,7 @@ static int free_segment_range(struct f2fs_sb_info *sbi,
> mutex_unlock(&DIRTY_I(sbi)->seglist_lock);
>
> /* Move out cursegs from the target range */
> - for (type = CURSEG_HOT_DATA; type < NR_CURSEG_PERSIST_TYPE; type++) {
> + for (type = CURSEG_HOT_DATA; type < NR_CURSEG_TYPE; type++) {
> err = f2fs_allocate_segment_for_resize(sbi, type, start, end);
> if (err)
> goto out;
^ permalink raw reply [flat|nested] 5+ messages in thread
* [f2fs-dev] [PATCH] f2fs: fix to migrate all curseg types during free_segment_range
@ 2026-08-19 18:06 ` Daeho Jeong
0 siblings, 0 replies; 5+ messages in thread
From: Daeho Jeong @ 2026-08-19 18:06 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel, kernel-team; +Cc: Daeho Jeong, stable
From: Daeho Jeong <daehojeong@google.com>
In free_segment_range(), the curseg evacuation loop only iterates up to
NR_CURSEG_PERSIST_TYPE (0..5), missing non-persistent in-memory curseg
types such as CURSEG_COLD_DATA_PINNED and CURSEG_ALL_DATA_ATGC.
Even though these in-memory curseg types are not saved in the on-disk
checkpoint header, they still occupy active physical segments at runtime.
If an active in-memory curseg happens to be allocated within the segment
range being truncated during filesystem shrink, failing to evacuate it
will cause subsequent writes to the curseg attempting out-of-bounds I/O
on the truncated storage range.
Fix this by expanding the curseg evacuation loop upper bound to
NR_CURSEG_TYPE to ensure all active curseg types are safely migrated
out of the target range.
Fixes: d0b9e42ab615 ("f2fs: introduce inmem curseg")
Cc: stable@vger.kernel.org
Signed-off-by: Daeho Jeong <daehojeong@google.com>
Signed-off-by: Sunmin Jeong <s_min.jeong@samsung.com>
---
fs/f2fs/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index ffaa7ba76a1b..192b16ac02f8 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -2222,7 +2222,7 @@ static int free_segment_range(struct f2fs_sb_info *sbi,
mutex_unlock(&DIRTY_I(sbi)->seglist_lock);
/* Move out cursegs from the target range */
- for (type = CURSEG_HOT_DATA; type < NR_CURSEG_PERSIST_TYPE; type++) {
+ for (type = CURSEG_HOT_DATA; type < NR_CURSEG_TYPE; type++) {
err = f2fs_allocate_segment_for_resize(sbi, type, start, end);
if (err)
goto out;
--
2.55.0.691.gc56d675ccc-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] f2fs: fix to migrate all curseg types during free_segment_range
@ 2026-08-19 18:06 ` Daeho Jeong
0 siblings, 0 replies; 5+ messages in thread
From: Daeho Jeong @ 2026-08-19 18:06 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel, kernel-team
Cc: Daeho Jeong, stable, Sunmin Jeong
From: Daeho Jeong <daehojeong@google.com>
In free_segment_range(), the curseg evacuation loop only iterates up to
NR_CURSEG_PERSIST_TYPE (0..5), missing non-persistent in-memory curseg
types such as CURSEG_COLD_DATA_PINNED and CURSEG_ALL_DATA_ATGC.
Even though these in-memory curseg types are not saved in the on-disk
checkpoint header, they still occupy active physical segments at runtime.
If an active in-memory curseg happens to be allocated within the segment
range being truncated during filesystem shrink, failing to evacuate it
will cause subsequent writes to the curseg attempting out-of-bounds I/O
on the truncated storage range.
Fix this by expanding the curseg evacuation loop upper bound to
NR_CURSEG_TYPE to ensure all active curseg types are safely migrated
out of the target range.
Fixes: d0b9e42ab615 ("f2fs: introduce inmem curseg")
Cc: stable@vger.kernel.org
Signed-off-by: Daeho Jeong <daehojeong@google.com>
Signed-off-by: Sunmin Jeong <s_min.jeong@samsung.com>
---
fs/f2fs/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index ffaa7ba76a1b..192b16ac02f8 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -2222,7 +2222,7 @@ static int free_segment_range(struct f2fs_sb_info *sbi,
mutex_unlock(&DIRTY_I(sbi)->seglist_lock);
/* Move out cursegs from the target range */
- for (type = CURSEG_HOT_DATA; type < NR_CURSEG_PERSIST_TYPE; type++) {
+ for (type = CURSEG_HOT_DATA; type < NR_CURSEG_TYPE; type++) {
err = f2fs_allocate_segment_for_resize(sbi, type, start, end);
if (err)
goto out;
--
2.55.0.691.gc56d675ccc-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-19 18:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-19 18:06 [f2fs-dev] [PATCH] f2fs: fix to migrate all curseg types during free_segment_range Daeho Jeong
2026-08-19 18:06 ` Daeho Jeong
-- strict thread matches above, loose matches on Subject: below --
2026-08-18 17:00 [f2fs-dev] " Daeho Jeong
2026-08-19 1:56 ` Chao Yu via Linux-f2fs-devel
2026-08-19 1:56 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.