All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rodrigo Gobbi" <rodrigo.gobbi.7@gmail.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: proximity: move LIDAR-Lite v2 out of trivial-devices
Date: Wed, 19 Aug 2026 21:07:07 +0000	[thread overview]
Message-ID: <20260819210708.48FE11F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260819205751.166030-2-rodrigo.gobbi.7@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Making `vdd-supply` strictly required breaks schema validation for all existing valid device trees.
--

--- Patch [1]: [PATCH v6 1/2] dt-bindings: iio: proximity: move LIDAR-Lite v2 out of trivial-devices ---
commit a1ef458d9c0cdfc9e29367cfdc33a99254dccf2e
Author: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>

dt-bindings: iio: proximity: move LIDAR-Lite v2 out of trivial-devices

The PulsedLight LIDAR-Lite v2 is moved out of trivial-devices into a dedicated
binding file to document its power-enable, power-supply, and interrupt
properties.

> diff --git a/Documentation/devicetree/bindings/iio/proximity/pulsedlight,lidar-lite-v2.yaml b/Documentation/devicetree/bindings/iio/proximity/pulsedlight,lidar-lite-v2.yaml
> new file mode 100644
> index 0000000000000..491960bb3a0e9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/pulsedlight,lidar-lite-v2.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply

[Severity: Low]
Does making vdd-supply strictly required break schema validation for existing
device trees?

Since this device was previously validated against trivial-devices.yaml where
this supply was not defined, running make dtbs_check with an older, valid
device tree containing pulsedlight,lidar-lite-v2 but lacking vdd-supply
will fail.

Should this property be optional to maintain backward compatibility with older
device trees?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260819205751.166030-1-rodrigo.gobbi.7@gmail.com?part=1

  reply	other threads:[~2026-08-19 21:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 20:55 [PATCH v6 0/2] iio: proximity: move LIDAR-Lite out of trivial-devices and add Garmin fallback Rodrigo Gobbi
2026-08-19 20:55 ` [PATCH v6 1/2] dt-bindings: iio: proximity: move LIDAR-Lite v2 out of trivial-devices Rodrigo Gobbi
2026-08-19 21:07   ` sashiko-bot [this message]
2026-08-19 20:55 ` [PATCH v6 2/2] dt-bindings: iio: proximity: document LIDAR-Lite v3 fallback compatible Rodrigo Gobbi
2026-08-20  1:40 ` [PATCH v6 0/2] iio: proximity: move LIDAR-Lite out of trivial-devices and add Garmin fallback Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819210708.48FE11F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rodrigo.gobbi.7@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.