Re: [PATCH v2 10/16] arm64: dts: qcom: sm8350: Add GCC CX power domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing 'power-domains' declaration in the qcom,gcc-sm8350.yaml device tree binding schema.
--

--- Patch [10]: [PATCH v2 10/16] arm64: dts: qcom: sm8350: Add GCC CX power domain ---
commit da0614dca1afbc3aae13d37f6ec085e9fcaa4394
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: sm8350: Add GCC CX power domain

This commit updates the sm8350 devicetree to add the RPMh CX power domain
reference to the GCC clock controller node. This allows votes from GCC GDSC
consumers to properly propagate to RPMh CX.

> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index 32b47f5ec1f67..84012a407c4be 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -699,6 +699,7 @@ gcc: clock-controller@100000 {
>  				 <&ufs_mem_phy 2>,
>  				 <&usb_1_qmpphy QMP_USB43DP_USB3_PIPE_CLK>,
>  				 <0>;
> +			power-domains = <&rpmhpd RPMHPD_CX>;

[Severity: Low]
Should this new property also be declared in the corresponding device tree
binding schema?

Looking at Documentation/devicetree/bindings/clock/qcom,gcc-sm8350.yaml,
adding the power-domains property to the devicetree node without explicitly
listing it in the binding schema's properties block can leave it unconstrained
and trigger an undocumented property warning during dtbs_check.

>  		};
>  
>  		ipcc: mailbox@408000 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-qcom-tie-cx-to-gcc-v2-0-e67ea30d8b7b@oss.qualcomm.com?part=10