Re: [PATCH v2 13/16] arm64: dts: qcom: sm8650: Add GCC CX power domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `power-domains` property is added to the SM8650 GCC device tree node without updating the corresponding binding schema, which will cause validation failures.
--

--- Patch [13]: [PATCH v2 13/16] arm64: dts: qcom: sm8650: Add GCC CX power domain ---
commit 2cea18fb279f0e36930dd295a87712e624b1a701
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: sm8650: Add GCC CX power domain

This commit adds the RPMh CX power domain reference to the GCC node on
SM8650. This ensures that the required CX vote is held when consumers
enable their local GCC-provided GDSCs.

> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index b679fd8afb7d5..962797c15abf5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -2019,6 +2019,8 @@ gcc: clock-controller@100000 {
>  				 <&ufs_mem_phy 2>,
>  				 <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>;
>  
> +			power-domains = <&rpmhpd RPMHPD_CX>;

[Severity: Low]
Will this new property cause dtbs_check validation failures?

Looking at Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml, the
schema enforces unevaluatedProperties: false. Does the binding schema also
need to be updated alongside this change to explicitly define and permit
the power-domains property for this node?

> +
>  			#clock-cells = <1>;
>  			#reset-cells = <1>;
>  			#power-domain-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-qcom-tie-cx-to-gcc-v2-0-e67ea30d8b7b@oss.qualcomm.com?part=13