(no subject)

[thomas_turner]

From 20f8cda9f788a2d19689f350bff3754ff3c24e3d Mon Sep 17 00:00:00 2001
From: Thomas Turner <tturner@lineageos.org>
Date: Wed, 19 Aug 2026 13:48:24 +0100
Subject: [PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node

This can provide basic GPU functionality for the Exynos850 platform.

Signed-off-by: Thomas Turner <tturner@lineageos.org>
---
 arch/arm64/boot/dts/exynos/exynos850.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
index 3881f573ec08..8ed85c125030 100644
--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
@@ -296,6 +296,18 @@ cmu_g3d: clock-controller@11400000 {
 			clock-names = "oscclk", "dout_g3d_switch";
 		};
 
+		gpu: gpu@11500000 {
+			compatible = "samsung,exynos850-mali", "arm,mali-bifrost";
+			reg = <0x11500000 0x5000>;
+			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&cmu_g3d CLK_GOUT_G3D_GPU_CLK>;
+			clock-names = "core";
+			status = "disabled";
+		};
+
 		cmu_apm: clock-controller@11800000 {
 			compatible = "samsung,exynos850-cmu-apm";
 			reg = <0x11800000 0x8000>;
-- 
2.47.3

Re:

[Sam Protsenko]

Hi Thomas,
On Wed, Aug 19, 2026 at 8:07 AM thomas_turner@talktalk.net
<thomas_turner@talktalk.net> wrote:
>
> From 20f8cda9f788a2d19689f350bff3754ff3c24e3d Mon Sep 17 00:00:00 2001
> From: Thomas Turner <tturner@lineageos.org>
> Date: Wed, 19 Aug 2026 13:48:24 +0100
> Subject: [PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node
>

The actual mail lacks the subject. Did you use "git send-email" or
"b4" to submit this patch?

> This can provide basic GPU functionality for the Exynos850 platform.
>

Can you please tell us a bit about how you tested this patch, and on
which board? As DPU is not currently enabled on Exynos850 SoC, I'm not
sure how exactly GPU can be useful. If you have a use case or a
testing procedure we can run on the E850-96 board, please share.

Would be nice to have a more detailed commit message overall. In
addition to the above, it probably makes sense to also discuss current
limitations. E.g. thermal, PD, and DVFS, which are enabled in the
downstream kernel's GPU node [1].

Thanks!

[1] https://gitlab.com/Linaro/96boards/e850-96/kernel/-/blob/android-exynos-4.14-linaro/arch/arm64/boot/dts/exynos/exynos3830.dts?ref_type=heads#L719

> Signed-off-by: Thomas Turner <tturner@lineageos.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos850.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> index 3881f573ec08..8ed85c125030 100644
> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> @@ -296,6 +296,18 @@ cmu_g3d: clock-controller@11400000 {
>                         clock-names = "oscclk", "dout_g3d_switch";
>                 };
>
> +               gpu: gpu@11500000 {
> +                       compatible = "samsung,exynos850-mali", "arm,mali-bifrost";
> +                       reg = <0x11500000 0x5000>;
> +                       interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "job", "mmu", "gpu";
> +                       clocks = <&cmu_g3d CLK_GOUT_G3D_GPU_CLK>;
> +                       clock-names = "core";
> +                       status = "disabled";
> +               };
> +
>                 cmu_apm: clock-controller@11800000 {
>                         compatible = "samsung,exynos850-cmu-apm";
>                         reg = <0x11800000 0x8000>;
> --
> 2.47.3
>

[PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node

[Thomas Turner]

This can provide basic GPU functionality for the Exynos850 platform.
Tested on the SM-A217F device. Does not provide support for temperature
throttling, DVFS, power domains, governor support, boosting and voltage
control. Once PMIC is properly implemented, support will hopefully
increase. However the panfrost driver probes, the Mali-G52 GPU
initializes and the core clock is set-up.

Signed-off-by: Thomas Turner <tturner@lineageos.org>
---
 arch/arm64/boot/dts/exynos/exynos850.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
index 3881f573ec08..8ed85c125030 100644
--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
@@ -296,6 +296,18 @@ cmu_g3d: clock-controller@11400000 {
 			clock-names = "oscclk", "dout_g3d_switch";
 		};
 
+		gpu: gpu@11500000 {
+			compatible = "samsung,exynos850-mali", "arm,mali-bifrost";
+			reg = <0x11500000 0x5000>;
+			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&cmu_g3d CLK_GOUT_G3D_GPU_CLK>;
+			clock-names = "core";
+			status = "disabled";
+		};
+
 		cmu_apm: clock-controller@11800000 {
 			compatible = "samsung,exynos850-cmu-apm";
 			reg = <0x11800000 0x8000>;
-- 
2.47.3

Re: [PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly introduced compatible string 'samsung,exynos850-mali' is not documented in the device tree bindings schema.
--

--- Patch [1]: [PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node ---
commit 358cd68635088d124d51d9f2284625ff11e03e28
Author: Thomas Turner <tturner@lineageos.org>

arm64: dts: exynos850: Add GPU/Mali Bifrost node

This commit adds a GPU node for the Exynos850 platform to provide basic GPU
functionality. The panfrost driver can probe the Mali-G52 GPU with core
clocks set up, though advanced power management features are not yet
supported.

> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> index 3881f573ec08d..8ed85c125030a 100644
> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> @@ -296,6 +296,18 @@ cmu_g3d: clock-controller@11400000 {
>  			clock-names = "oscclk", "dout_g3d_switch";
>  		};
>  
> +		gpu: gpu@11500000 {
> +			compatible = "samsung,exynos850-mali", "arm,mali-bifrost";

[Severity: Low]
Is the new compatible string samsung,exynos850-mali documented in the
device tree bindings schema?

It appears this SoC-specific compatible string lacks a corresponding entry in
the dt-bindings documentation (e.g.
Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml). This will
likely cause make dtbs_check to emit warnings or fail validation for this
device tree file.

> +			reg = <0x11500000 0x5000>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820133556.76300-1-tturner@lineageos.org?part=1

Re: [PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node

[Krzysztof Kozlowski]

On 20/08/2026 15:35, Thomas Turner wrote:
> This can provide basic GPU functionality for the Exynos850 platform.
> Tested on the SM-A217F device. Does not provide support for temperature

How? The node is disabled.

Please respond to actual comments you received before.

Also, you need to version your patches correctly. This is v2. You also
need changelog under ---.

Best regards,
Krzysztof

[PATCH v2 0/2] Exynos850 GPU support

[Thomas Turner]

Hi all,
This is my first time sending patches to linux so apologies for
mistakes. This series provides basic GPU support to the Exynos850
platform, making use of the Mali G52 GPU through the panfrost driver.

Thomas Turner (2):
  dt-bindings: gpu: arm,mali-bifrost: add exynos850-mali compatible
  arm64: dts: exynos850: Add GPU/Mali Bifrost node

 .../devicetree/bindings/gpu/arm,mali-bifrost.yaml    |  1 +
 arch/arm64/boot/dts/exynos/exynos850.dtsi            | 12 ++++++++++++
 2 files changed, 13 insertions(+)

-- 
2.47.3

[PATCH v2 1/2] dt-bindings: gpu: arm,mali-bifrost: add exynos850-mali compatible

[Thomas Turner]

Exynos850 SoC uses the ARM Mali G52 GPU, document its compatible
string with the appropriate fallback.

Signed-off-by: Thomas Turner <tturner@lineageos.org>
---
 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
index 9db9f84ad964..ece2b637cd41 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
@@ -34,6 +34,7 @@ properties:
               - rockchip,rk3562-mali
               - rockchip,rk3568-mali
               - rockchip,rk3576-mali
+              - samsung,exynos850-mali
           - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable
       - items:
           - enum:
-- 
2.47.3

[PATCH v2 2/2] arm64: dts: exynos850: Add GPU/Mali Bifrost node

[Thomas Turner]

This can provide basic GPU functionality for the Exynos850 platform.
Tested on the SM-A217F device. Does not provide support for temperature
throttling, DVFS, power domains, governor support, boosting and voltage
control. Once PMIC is properly implemented, support will hopefully
increase. However the panfrost driver probes, the Mali-G52 GPU
initializes and the core clock is set-up.

Signed-off-by: Thomas Turner <tturner@lineageos.org>
---
 arch/arm64/boot/dts/exynos/exynos850.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
index 3881f573ec08..8ed85c125030 100644
--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
@@ -296,6 +296,18 @@ cmu_g3d: clock-controller@11400000 {
 			clock-names = "oscclk", "dout_g3d_switch";
 		};
 
+		gpu: gpu@11500000 {
+			compatible = "samsung,exynos850-mali", "arm,mali-bifrost";
+			reg = <0x11500000 0x5000>;
+			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&cmu_g3d CLK_GOUT_G3D_GPU_CLK>;
+			clock-names = "core";
+			status = "disabled";
+		};
+
 		cmu_apm: clock-controller@11800000 {
 			compatible = "samsung,exynos850-cmu-apm";
 			reg = <0x11800000 0x8000>;
-- 
2.47.3

Re: [PATCH v2 0/2] Exynos850 GPU support

[Krzysztof Kozlowski]

On 20/08/2026 16:23, Thomas Turner wrote:
> Hi all,
> This is my first time sending patches to linux so apologies for
> mistakes. This series provides basic GPU support to the Exynos850
> platform, making use of the Mali G52 GPU through the panfrost driver.
> 

Again: slow down.

Why does this appear under empty subject thread?

Best regards,
Krzysztof

Re: [PATCH v2 0/2] Exynos850 GPU support

[thomas_turner@talktalk.net]

Apologies, I think I am missing the --thread parameter. The command I ran was

git send-email --in-reply-to='<GVYP280MB12139AB976CA7ACF49FEB768A1A52@GVYP280MB1213.SWEP280.PROD.OUTLOOK.COM>' \
    --to='etc' \
    --cc='etc' \
    v2-000*.patch


I want to avoid spamming the mailing list with null information so I would appreciate some guidance on what I am doing wrong. In regards to your comment, I left it disabled as I was initially unsure whether the E850-96 Board uses Mali G52, however it seems all exynos850 devices share the same GPU, would it be better to have as status="okay"  ?

As for the comments I believe I already responded to them but I am testing this on the Samsung Galaxy A21s and here are some logs I pulled.
[    0.230437] panfrost 11500000.gpu: clock rate = 377000000
[    0.230863] panfrost 11500000.gpu: mali-g52 id 0x7212 major 0x0 minor 0x0 status 0x0
[    0.230945] panfrost 11500000.gpu: features: 00000000,00000df7, issues: 00000000,00000400
[    0.231026] panfrost 11500000.gpu: Features: L2:0x07100206 Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002830 AS:0xff JS:0x7
[    0.231137] panfrost 11500000.gpu: shader_present=0x1 l2_present=0x1
[    0.232552] panfrost 11500000.gpu: [drm] Using Transparent Hugepage
[    0.233172] [drm] Initialized panfrost 1.6.0 for 11500000.gpu on minor 0

________________________________________
From: thomas_turner@talktalk.net <thomas_turner@talktalk.net>
Sent: Thursday, August 20, 2026 7:39 AM
To: Krzysztof Kozlowski; Thomas Turner
Cc: semen.protsenko@linaro.org; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; peter.griffin@linaro.org; alim.akhtar@samsung.com; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Exynos850 GPU support

Apologies, I think I am missing the --thread parameter. The command I ran was

git send-email --in-reply-to='<GVYP280MB12139AB976CA7ACF49FEB768A1A52@GVYP280MB1213.SWEP280.PROD.OUTLOOK.COM>' \
    --to='etc' \
    --cc='etc' \
    v2-000*.patch


I want to avoid spamming the mailing list with null information so I would appreciate some guidance on what I am doing wrong. In regards to your comment, I left it disabled as I was initially unsure whether the E850-96 Board uses Mali G52, however it seems all exynos850 devices share the same GPU, would it be better to have as status="okay"  ?

As for the comments I believe I already responded to them but I am testing this on the Samsung Galaxy A21s and here are some logs I pulled.
[    0.230437] panfrost 11500000.gpu: clock rate = 377000000
[    0.230863] panfrost 11500000.gpu: mali-g52 id 0x7212 major 0x0 minor 0x0 status 0x0
[    0.230945] panfrost 11500000.gpu: features: 00000000,00000df7, issues: 00000000,00000400
[    0.231026] panfrost 11500000.gpu: Features: L2:0x07100206 Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002830 AS:0xff JS:0x7
[    0.231137] panfrost 11500000.gpu: shader_present=0x1 l2_present=0x1
[    0.232552] panfrost 11500000.gpu: [drm] Using Transparent Hugepage
[    0.233172] [drm] Initialized panfrost 1.6.0 for 11500000.gpu on minor 0

________________________________________
From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Sent: Thursday, August 20, 2026 7:28 AM
To: Thomas Turner; krzysztof.kozlowski@oss.qualcomm.com
Cc: semen.protsenko@linaro.org; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; peter.griffin@linaro.org; alim.akhtar@samsung.com; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Exynos850 GPU support

On 20/08/2026 16:23, Thomas Turner wrote:
> Hi all,
> This is my first time sending patches to linux so apologies for
> mistakes. This series provides basic GPU support to the Exynos850
> platform, making use of the Mali G52 GPU through the panfrost driver.
>

Again: slow down.

Why does this appear under empty subject thread?

Best regards,
Krzysztof

Re: [PATCH v2 0/2] Exynos850 GPU support

[Krzysztof Kozlowski]

On 20/08/2026 18:22, thomas_turner@talktalk.net wrote:
> 
> Apologies, I think I am missing the --thread parameter. The command I ran was
> 
> git send-email --in-reply-to='<GVYP280MB12139AB976CA7ACF49FEB768A1A52@GVYP280MB1213.SWEP280.PROD.OUTLOOK.COM>' \

You almost never use this parameter.

git format patch; scripts/getmaintainers; git send email

Or just use b4 as all recent guides are asking
https://www.linaro.org/blog/becoming-a-kernel-developer-part1-posting-your-first-patch/

Please read:
https://subspace.kernel.org/etiquette.html


Best regards,
Krzysztof