All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] tools: build mkeficapsule for CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y
@ 2026-08-20  7:26 Heinrich Schuchardt
  2026-08-20 13:21 ` Linus Walleij
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2026-08-20  7:26 UTC (permalink / raw)
  To: Tom Rini
  Cc: Linus Walleij, Ilias Apalodimas, Kory Maincent, u-boot,
	Heinrich Schuchardt

Currently we build mkeficapsule by default even if we don't have EFI
capsule support enabled. This adds a host GnuTLS build dependency.

Only build mkeficapsule by default if CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y.

tools-only_defconfig explicitly selects CONFIG_TOOLS_MKEFICAPSULE=y.
Hence distro packages like Debian's u-boot-tools will still contain
mkeficapsule.

Reported-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 tools/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/Kconfig b/tools/Kconfig
index ef33295b8ec..e151b30217e 100644
--- a/tools/Kconfig
+++ b/tools/Kconfig
@@ -108,7 +108,7 @@ config TOOLS_SHA512
 
 config TOOLS_MKEFICAPSULE
 	bool "Build efimkcapsule command"
-	default y if EFI_LOADER
+	default y if EFI_HAVE_CAPSULE_SUPPORT
 	help
 	  This command allows users to create a UEFI capsule file and,
 	  optionally sign that file. If you want to enable UEFI capsule
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] tools: build mkeficapsule for CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y
  2026-08-20  7:26 [PATCH 1/1] tools: build mkeficapsule for CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y Heinrich Schuchardt
@ 2026-08-20 13:21 ` Linus Walleij
  2026-08-20 14:55 ` Tom Rini
  2026-08-20 15:02 ` Kory Maincent
  2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2026-08-20 13:21 UTC (permalink / raw)
  To: Heinrich Schuchardt; +Cc: Tom Rini, Ilias Apalodimas, Kory Maincent, u-boot

On Thu, Aug 20, 2026 at 9:27 AM Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:

> Currently we build mkeficapsule by default even if we don't have EFI
> capsule support enabled. This adds a host GnuTLS build dependency.
>
> Only build mkeficapsule by default if CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y.
>
> tools-only_defconfig explicitly selects CONFIG_TOOLS_MKEFICAPSULE=y.
> Hence distro packages like Debian's u-boot-tools will still contain
> mkeficapsule.
>
> Reported-by: Linus Walleij <linusw@kernel.org>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Looks right to me!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] tools: build mkeficapsule for CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y
  2026-08-20  7:26 [PATCH 1/1] tools: build mkeficapsule for CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y Heinrich Schuchardt
  2026-08-20 13:21 ` Linus Walleij
@ 2026-08-20 14:55 ` Tom Rini
  2026-08-20 15:02 ` Kory Maincent
  2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2026-08-20 14:55 UTC (permalink / raw)
  To: Heinrich Schuchardt
  Cc: Linus Walleij, Ilias Apalodimas, Kory Maincent, u-boot

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

On Thu, Aug 20, 2026 at 09:26:45AM +0200, Heinrich Schuchardt wrote:

> Currently we build mkeficapsule by default even if we don't have EFI
> capsule support enabled. This adds a host GnuTLS build dependency.
> 
> Only build mkeficapsule by default if CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y.
> 
> tools-only_defconfig explicitly selects CONFIG_TOOLS_MKEFICAPSULE=y.
> Hence distro packages like Debian's u-boot-tools will still contain
> mkeficapsule.
> 
> Reported-by: Linus Walleij <linusw@kernel.org>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

This should address the similar type problems other people and platforms
have reported too.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] tools: build mkeficapsule for CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y
  2026-08-20  7:26 [PATCH 1/1] tools: build mkeficapsule for CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y Heinrich Schuchardt
  2026-08-20 13:21 ` Linus Walleij
  2026-08-20 14:55 ` Tom Rini
@ 2026-08-20 15:02 ` Kory Maincent
  2 siblings, 0 replies; 4+ messages in thread
From: Kory Maincent @ 2026-08-20 15:02 UTC (permalink / raw)
  To: Heinrich Schuchardt, Tom Rini; +Cc: Linus Walleij, Ilias Apalodimas, u-boot



On 8/20/26 09:26, Heinrich Schuchardt wrote:
> Currently we build mkeficapsule by default even if we don't have EFI
> capsule support enabled. This adds a host GnuTLS build dependency.
> 
> Only build mkeficapsule by default if CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y.
> 
> tools-only_defconfig explicitly selects CONFIG_TOOLS_MKEFICAPSULE=y.
> Hence distro packages like Debian's u-boot-tools will still contain
> mkeficapsule.

Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>

Thank you!

--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-08-20 15:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-20  7:26 [PATCH 1/1] tools: build mkeficapsule for CONFIG_EFI_HAVE_CAPSULE_SUPPORT=y Heinrich Schuchardt
2026-08-20 13:21 ` Linus Walleij
2026-08-20 14:55 ` Tom Rini
2026-08-20 15:02 ` Kory Maincent

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.