All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC] kernel/ review rules
@ 2026-08-21  0:20 Bradley Morgan
  2026-08-21  1:00 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Bradley Morgan @ 2026-08-21  0:20 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm, pmladek

(CCed some people I talk to loads, I don't think I should CC every single
kernel/ maintainer, that would be fun otherwise, if you feel others should
be CCed, please CC them)

Hey everyone, it's been about God knows how long since I've started
reviewing kernel/, here are my current stats:
    
Reviewed-by     
13
Tested-by          
7
Reported-by        
1

Pretty good, ngl, I'm happy to review these patches, and I'm happy to
review the slop patches, and the people's patches, and anything with
[PATCH] in the damn title.

My very kind slop tool generated these stats for me.. 

So I've had some controversy about, like, how I do these reviews, some
people say how I review without context, or other stuff, like I'm wrong.

And I would like to suggest a fix to this, stuff.

So, when I do reviews from now on, if I haven't reviewed the patch
super vigourisly, e.g: for nits, or for like little things, instead of
adding my R-B, I'll add this instead:

Acked-by: Bradley Morgan <include@grrlz.net>

Thanks for letting me review kernel/ patches!



Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFC] kernel/ review rules
  2026-08-21  0:20 [RFC] kernel/ review rules Bradley Morgan
@ 2026-08-21  1:00 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2026-08-21  1:00 UTC (permalink / raw)
  To: Bradley Morgan; +Cc: linux-kernel, pmladek

On Fri, 21 Aug 2026 01:20:47 +0100 Bradley Morgan <include@grrlz.net> wrote:

> So, when I do reviews from now on, if I haven't reviewed the patch
> super vigourisly, e.g: for nits, or for like little things, instead of
> adding my R-B, I'll add this instead:
> 
> Acked-by: Bradley Morgan <include@grrlz.net>

That's conventional.

Here's my interpretation:

Acked-by:			"cool changelog!"
Reviewed-by: + nothing		"cool changelog and I scrolled through it"
Reviewed-by: + commentary:	"I reviewed it!"


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-21  1:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21  0:20 [RFC] kernel/ review rules Bradley Morgan
2026-08-21  1:00 ` Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.