From: Yixun Lan <dlan@kernel.org>
To: Eric Chung <eric.chung@riscstar.com>
Cc: u-boot-spacemit@groups.io, u-boot@lists.u-boot-project.org,
Tom Rini <trini@konsulko.com>, Tim Ouyang <tim609@andestech.com>,
Leo Liang <leo.liang@sifive.com>, Peng Fan <peng.fan@nxp.com>,
Huan Zhou <pericycle.cc@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>,
Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
Kaustabh Chakraborty <kauschluss@disroot.org>,
Han Xu <han.xu@nxp.com>, Yanir Levin <yanir.levin@tandemg.com>,
Christoph Stoidner <c.stoidner@phytec.de>,
Balsundar Ponnusamy <balsundar.ponnusamy@altera.com>,
Daniel Palmer <daniel@thingy.jp>, Anshul Dalal <anshuld@ti.com>,
Bastien Curutchet <bastien.curutchet@bootlin.com>,
Angelo Dureghello <angelo@kernel-space.org>,
Johan Jonker <jbx6244@gmail.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Guodong Xu <guodong@riscstar.com>, Yao Zi <me@ziyao.cc>,
Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
Yixun Lan <dlan@kenrel.org>, Alex Elder <elder@riscstar.com>,
Yixun Lan <dlan@gentoo.org>,
Iker Pedrosa <ikerpedrosam@gmail.com>,
Anand Moon <linux.amoon@gmail.com>,
Trevor Gamblin <tgamblin@baylibre.com>,
Vincent Legoll <legoll@online.fr>,
Troy Mitchell <troy.mitchell@linux.dev>,
Margherita Milani <margherita.milani@amarulasolutions.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Andre Heider <a.heider@gmail.com>
Subject: Re: [PATCH v9 00/19] spacemit mmc driver
Date: Fri, 21 Aug 2026 16:42:57 +0000 [thread overview]
Message-ID: <20260821164257-GKA579897@kernel.org> (raw)
In-Reply-To: <20260819-m4-v9-0-6e66016392b9@riscstar.com>
Hi Eric
On 11:54 Wed 19 Aug , Eric Chung wrote:
> This series adds MMC support for the SpacemiT K1: an SDHCI platform
> driver, the SD card device-tree overlay, defconfig options, and SPL
> boot-device selection from the SoC strap/config registers. The SDHCI
> driver is usable in both SPL and U-Boot proper.
>
> A flashing guide (doc/board/spacemit/k1-flash.rst) describes how to
> write images to eMMC.
>
> ---
> Changes in v9:
> - spl: Enhance detection on booting from SD.
> - dts: Synched upstream DTS files for K1.
> - doc: Create SD card image from scratch.
> - mmc: Avoid to use CMD18 on SD card in SPL.
..
> - pinctrl: Drop "fix drive strength configuration".
Could you please explain why this patch is dropped?
It looks valid to me, also it fix a problem that setting drive strength
actually clear out other pin conf bits which lead to serious bug
- clrsetbits_le32(addr, PAD_DRIVE, ds);
+ clrsetbits_le32(addr, PAD_DRIVE, FIELD_PREP(PAD_DRIVE, ds));
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-08-21 18:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 3:54 [PATCH v9 00/19] spacemit mmc driver Eric Chung
2026-08-19 3:54 ` [PATCH v9 01/19] spacemit: k1: select boot device via config registers Eric Chung
2026-08-19 3:54 ` [PATCH v9 02/19] pinctrl: k1: fix pull-up/pull-down configuration Eric Chung
2026-08-21 16:54 ` Yixun Lan
2026-08-19 3:54 ` [PATCH v9 03/19] pinctrl: k1: add IO power domain configuration support Eric Chung
2026-08-19 3:54 ` [PATCH v9 04/19] mmc: k1: add sdhci platform driver Eric Chung
2026-08-19 3:54 ` [PATCH v9 05/19] riscv: dts: spacemit: define a SPI controller node Eric Chung
2026-08-19 3:54 ` [PATCH v9 06/19] riscv: dts: spacemit: k1: add SD card controller and pinctrl support Eric Chung
2026-08-19 3:54 ` [PATCH v9 07/19] riscv: dts: spacemit: k1-bananapi-f3: add SD card support with UHS modes Eric Chung
2026-08-19 3:54 ` [PATCH v9 08/19] riscv: dts: spacemit: k1-musepi-pro: add PMIC and power infrastructure Eric Chung
2026-08-19 3:54 ` [PATCH v9 09/19] riscv: dts: spacemit: k1-musepi-pro: add 24c02 eeprom Eric Chung
2026-08-19 3:54 ` [PATCH v9 10/19] riscv: dts: spacemit: k1-musepi-pro: enable QSPI and add SPI NOR Eric Chung
2026-08-19 3:54 ` [PATCH v9 11/19] riscv: dts: spacemit: k1-musepi-pro: enable USB 3 ports Eric Chung
2026-08-19 3:54 ` [PATCH v9 12/19] riscv: dts: spacemit: k1-musepi-pro: enable PCIe ports Eric Chung
2026-08-19 3:54 ` [PATCH v9 13/19] riscv: dts: spacemit: k1-musepi-pro: set default console baud rate Eric Chung
2026-08-19 3:54 ` [PATCH v9 14/19] riscv: dts: spacemit: k1-musepi-pro: add SD card support with UHS modes Eric Chung
2026-08-19 3:54 ` [PATCH v9 15/19] dts: k1: enable mmc devices in SPL Eric Chung
2026-08-19 3:54 ` [PATCH v9 16/19] configs: k1: enable SD and eMMC support Eric Chung
2026-08-19 3:54 ` [PATCH v9 17/19] MAINTAINER: update Spacemit K1 entry Eric Chung
2026-08-19 3:55 ` [PATCH v9 18/19] doc: spacemit: flash on K1 SoC based boards Eric Chung
2026-08-19 3:55 ` [PATCH v9 19/19] spacemit: k1: fix product name detection and DTB matching in SPL Eric Chung
2026-08-19 12:59 ` [PATCH v9 00/19] spacemit mmc driver Iker Pedrosa
2026-08-20 2:06 ` Eric Chung
2026-08-20 9:27 ` Iker Pedrosa
2026-08-21 16:42 ` Yixun Lan [this message]
2026-08-22 0:47 ` Eric Chung
2026-08-22 1:29 ` Eric Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821164257-GKA579897@kernel.org \
--to=dlan@kernel.org \
--cc=a.heider@gmail.com \
--cc=angelo@kernel-space.org \
--cc=anshuld@ti.com \
--cc=aurelien@aurel32.net \
--cc=balsundar.ponnusamy@altera.com \
--cc=bastien.curutchet@bootlin.com \
--cc=bhimeswararao.matsa@gmail.com \
--cc=c.stoidner@phytec.de \
--cc=daniel@thingy.jp \
--cc=dlan@gentoo.org \
--cc=dlan@kenrel.org \
--cc=elder@riscstar.com \
--cc=eric.chung@riscstar.com \
--cc=guodong@riscstar.com \
--cc=han.xu@nxp.com \
--cc=ikerpedrosam@gmail.com \
--cc=jbx6244@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=kauschluss@disroot.org \
--cc=legoll@online.fr \
--cc=leo.liang@sifive.com \
--cc=linux.amoon@gmail.com \
--cc=margherita.milani@amarulasolutions.com \
--cc=me@ziyao.cc \
--cc=peng.fan@nxp.com \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=rick@andestech.com \
--cc=semen.protsenko@linaro.org \
--cc=tanmay.kathpalia@altera.com \
--cc=tgamblin@baylibre.com \
--cc=tim609@andestech.com \
--cc=trini@konsulko.com \
--cc=troy.mitchell@linux.dev \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
--cc=yanir.levin@tandemg.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.