Re: [PATCH v9 02/19] pinctrl: k1: fix pull-up/pull-down configuration

[Yixun Lan <dlan@kernel.org>]

Hi Eirc,

On 11:54 Wed 19 Aug     , Eric Chung wrote:
> Fix pull-up/pull-down configuration to honor the argument parameter:
> when argument is non-zero, enable the requested pull direction;
> when argument is zero, clear all pull bits to disable.
> 
> Signed-off-by: Eric Chung <eric.chung@riscstar.com>
..
> Reviewed-by: Yixun Lan <dlan@kenrel.org>
No, I never gave R-B to this patch, and below you still not addressed
my previous concern

Also, I suggest to use tool "b4 trailers" to collect tags instead of
 doing it manually which easily lead to problem..
> 
> ---
> v9:
> - Rebase since drop patch "fix drive strength configuration".
> v7:
> - Simplify pull-up/pull-down configuration by using a single
>   clrsetbits_le32() call.
> v6:
> - Fix pull-up/pull-down configuration.
> ---
>  drivers/pinctrl/spacemit/pinctrl-k1.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
> index a6a22eacac7b..9ca4ef7c771e 100644
> --- a/drivers/pinctrl/spacemit/pinctrl-k1.c
> +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c

..
>  	case PIN_CONFIG_BIAS_PULL_UP:
> -		mask = PAD_PULLDOWN | PAD_PULLUP | PAD_PULL_EN;
> -		clrsetbits_le32(addr, mask, PAD_PULLUP | PAD_PULL_EN);
> +		clrsetbits_le32(addr, PAD_PULLDOWN | PAD_PULLUP | PAD_PULL_EN,
> +				argument ? PAD_PULLUP | PAD_PULL_EN : 0);
No, this is still same problem as previous version, please take
a look at the DT documentation from upstream linux kernel

Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml

1) to disable bias
          bias-disable: true

2) to set as pull down
          bias-pull-down: true

3) to set normal pull up or strong pull up
          bias-pull-up:
              0: normal bias pull up
              1: strong bias pull up

-- 
Yixun Lan (dlan)