* [to-be-updated] maple_tree-add-helper-mas_make_walkable.patch removed from -mm tree
@ 2026-08-21 22:22 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-08-21 22:22 UTC (permalink / raw)
To: mm-commits, liam, akpm
The quilt patch titled
Subject: maple_tree: add helper mas_make_walkable()
has been removed from the -mm tree. Its filename was
maple_tree-add-helper-mas_make_walkable.patch
This patch was dropped because an updated version will be issued
------------------------------------------------------
From: "Liam R. Howlett (Oracle)" <liam@infradead.org>
Subject: maple_tree: add helper mas_make_walkable()
Date: Tue, 30 Jun 2026 15:08:43 -0400
A check in mas_walk() was incorrect and caused inefficient use of the
maple state. The same issue existed in mas_erase(), but was left unfixed.
Making a helper function is the obvious answer.
Link: https://lore.kernel.org/20260630190843.3563858-20-liam@infradead.org
Signed-off-by: Liam R. Howlett (Oracle) <liam@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Chris Mason <clm@meta.com>
Cc: Chuck Lever <cel@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Joe Perches <joe@perches.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Waiman Long <longman@redhat.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/maple_tree.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
--- a/lib/maple_tree.c~maple_tree-add-helper-mas_make_walkable
+++ a/lib/maple_tree.c
@@ -261,6 +261,12 @@ static inline bool mas_is_underflow(stru
return mas->status == ma_underflow;
}
+static inline void mas_make_walkable(struct ma_state *mas)
+{
+ if (!mas_is_active(mas) && !mas_is_start(mas))
+ mas->status = ma_start;
+}
+
static __always_inline struct maple_node *mte_to_node(
const struct maple_enode *entry)
{
@@ -4447,8 +4453,7 @@ void *mas_walk(struct ma_state *mas)
void *entry;
mas_may_init_lock_check(mas);
- if (!mas_is_active(mas) && !mas_is_start(mas))
- mas->status = ma_start;
+ mas_make_walkable(mas);
retry:
entry = mas_state_walk(mas);
if (mas_is_start(mas)) {
@@ -5684,9 +5689,7 @@ void *mas_erase(struct ma_state *mas)
if (mt_external_lock(mas->tree))
might_alloc(GFP_KERNEL);
- if (!mas_is_active(mas) || !mas_is_start(mas))
- mas->status = ma_start;
-
+ mas_make_walkable(mas);
write_retry:
entry = mas_state_walk(mas);
if (!entry)
_
Patches currently in -mm which might be from liam@infradead.org are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-21 22:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 22:22 [to-be-updated] maple_tree-add-helper-mas_make_walkable.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.