diff for duplicates of <202608221220.dvi7OT84-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index a896f77..5af1f42 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,34 +1,13 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -In-Reply-To: <20260814065920.413487-1-hildawu@realtek.com> -References: <20260814065920.413487-1-hildawu@realtek.com> -TO: Hilda Wu <hildawu@realtek.com> -TO: marcel@holtmann.org -CC: luiz.dentz@gmail.com -CC: linux-bluetooth@vger.kernel.org -CC: linux-kernel@vger.kernel.org -CC: alex_lu@realsil.com.cn -CC: jason_mao@realsil.com.cn -CC: zoey_zhou@realsil.com.cn -CC: max.chou@realtek.com -CC: kidman@realtek.com - Hi Hilda, kernel test robot noticed the following build warnings: -[auto build test WARNING on bluetooth/master] -[also build test WARNING on bluetooth-next/master linus/master v7.2 next-20260820] -[If your patch is applied to the wrong git tree, kindly drop us a note. -And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Hilda-Wu/Bluetooth-btrtl-Add-firmware-format-v3-support/20260814-145920 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master patch link: https://lore.kernel.org/r/20260814065920.413487-1-hildawu%40realtek.com patch subject: [PATCH v6] Bluetooth: btrtl: Add firmware format v3 support -:::::: branch date: 27 hours ago -:::::: commit date: 27 hours ago config: x86_64-randconfig-161 (https://download.01.org/0day-ci/archive/20260822/202608221220.dvi7OT84-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb @@ -47,7 +26,6 @@ drivers/bluetooth/btrtl.c:1326 btrtl_initialize() warn: passing zero to 'ERR_PTR vim +/btrtl_dev +1106 drivers/bluetooth/btrtl.c -c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1093 26503ad25de8c7c Martin Blumenstingl 2018-08-02 1094 void btrtl_free(struct btrtl_device_info *btrtl_dev) 26503ad25de8c7c Martin Blumenstingl 2018-08-02 1095 { 9a24ce5e29b15c4 Max Chou 2023-04-17 1096 struct rtl_subsection *entry, *tmp; @@ -61,6 +39,10 @@ c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1093 9a24ce5e29b15c4 Max Chou 2023-04-17 1104 } 9a24ce5e29b15c4 Max Chou 2023-04-17 1105 8e4d5e1dbe2345c Hilda Wu 2026-08-14 @1106 if (btrtl_dev) { + +No point in checking for NULL when we have already dereferenced +btrtl_dev so many times. + 8e4d5e1dbe2345c Hilda Wu 2026-08-14 1107 struct btrtl_enh_ops *ops = symbol_get(rtl_enh_ops); 8e4d5e1dbe2345c Hilda Wu 2026-08-14 1108 8e4d5e1dbe2345c Hilda Wu 2026-08-14 1109 if (ops) { @@ -72,8 +54,6 @@ c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1093 8e4d5e1dbe2345c Hilda Wu 2026-08-14 1115 26503ad25de8c7c Martin Blumenstingl 2018-08-02 1116 kfree(btrtl_dev); 26503ad25de8c7c Martin Blumenstingl 2018-08-02 1117 } -26503ad25de8c7c Martin Blumenstingl 2018-08-02 1118 EXPORT_SYMBOL_GPL(btrtl_free); -26503ad25de8c7c Martin Blumenstingl 2018-08-02 1119 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index c9db483..b020343 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,42 +1,32 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "ref\020260814065920.413487-1-hildawu@realtek.com\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0Re: [PATCH v6] Bluetooth: btrtl: Add firmware format v3 support\0" - "Date\0Sat, 22 Aug 2026 12:27:30 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Sat, 22 Aug 2026 11:10:24 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + Hilda Wu <hildawu@realtek.com> + " marcel@holtmann.org\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + luiz.dentz@gmail.com + linux-bluetooth@vger.kernel.org + linux-kernel@vger.kernel.org + alex_lu@realsil.com.cn + jason_mao@realsil.com.cn + zoey_zhou@realsil.com.cn + max.chou@realtek.com + " kidman@realtek.com\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "In-Reply-To: <20260814065920.413487-1-hildawu@realtek.com>\n" - "References: <20260814065920.413487-1-hildawu@realtek.com>\n" - "TO: Hilda Wu <hildawu@realtek.com>\n" - "TO: marcel@holtmann.org\n" - "CC: luiz.dentz@gmail.com\n" - "CC: linux-bluetooth@vger.kernel.org\n" - "CC: linux-kernel@vger.kernel.org\n" - "CC: alex_lu@realsil.com.cn\n" - "CC: jason_mao@realsil.com.cn\n" - "CC: zoey_zhou@realsil.com.cn\n" - "CC: max.chou@realtek.com\n" - "CC: kidman@realtek.com\n" - "\n" "Hi Hilda,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" - "[auto build test WARNING on bluetooth/master]\n" - "[also build test WARNING on bluetooth-next/master linus/master v7.2 next-20260820]\n" - "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" - "And when submitting patch, we suggest to use '--base' as documented in\n" "https://git-scm.com/docs/git-format-patch#_base_tree_information]\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Hilda-Wu/Bluetooth-btrtl-Add-firmware-format-v3-support/20260814-145920\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master\n" "patch link: https://lore.kernel.org/r/20260814065920.413487-1-hildawu%40realtek.com\n" "patch subject: [PATCH v6] Bluetooth: btrtl: Add firmware format v3 support\n" - ":::::: branch date: 27 hours ago\n" - ":::::: commit date: 27 hours ago\n" "config: x86_64-randconfig-161 (https://download.01.org/0day-ci/archive/20260822/202608221220.dvi7OT84-lkp@intel.com/config)\n" "compiler: gcc-14 (Debian 14.2.0-19) 14.2.0\n" "smatch: v0.5.0-9187-g5189e3fb\n" @@ -55,7 +45,6 @@ "\n" "vim +/btrtl_dev +1106 drivers/bluetooth/btrtl.c\n" "\n" - "c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1093 \n" "26503ad25de8c7c Martin Blumenstingl 2018-08-02 1094 void btrtl_free(struct btrtl_device_info *btrtl_dev)\n" "26503ad25de8c7c Martin Blumenstingl 2018-08-02 1095 {\n" "9a24ce5e29b15c4 Max Chou 2023-04-17 1096 \tstruct rtl_subsection *entry, *tmp;\n" @@ -69,6 +58,10 @@ "9a24ce5e29b15c4 Max Chou 2023-04-17 1104 \t}\n" "9a24ce5e29b15c4 Max Chou 2023-04-17 1105 \n" "8e4d5e1dbe2345c Hilda Wu 2026-08-14 @1106 \tif (btrtl_dev) {\n" + "\n" + "No point in checking for NULL when we have already dereferenced\n" + "btrtl_dev so many times.\n" + "\n" "8e4d5e1dbe2345c Hilda Wu 2026-08-14 1107 \t\tstruct btrtl_enh_ops *ops = symbol_get(rtl_enh_ops);\n" "8e4d5e1dbe2345c Hilda Wu 2026-08-14 1108 \n" "8e4d5e1dbe2345c Hilda Wu 2026-08-14 1109 \t\tif (ops) {\n" @@ -80,11 +73,9 @@ "8e4d5e1dbe2345c Hilda Wu 2026-08-14 1115 \n" "26503ad25de8c7c Martin Blumenstingl 2018-08-02 1116 \tkfree(btrtl_dev);\n" "26503ad25de8c7c Martin Blumenstingl 2018-08-02 1117 }\n" - "26503ad25de8c7c Martin Blumenstingl 2018-08-02 1118 EXPORT_SYMBOL_GPL(btrtl_free);\n" - "26503ad25de8c7c Martin Blumenstingl 2018-08-02 1119 \n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -2e4407e19a0b529a01f804d45f50730c6db4ca9de9802a321f09ff64ced272c7 +fdf04867feb107a121027529ea1ce10dfa6a215c2f3743bd7fa610972964ec24
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.