From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v6] Bluetooth: btrtl: Add firmware format v3 support
Date: Sat, 22 Aug 2026 12:27:30 +0800 [thread overview]
Message-ID: <202608221220.dvi7OT84-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260814065920.413487-1-hildawu@realtek.com>
References: <20260814065920.413487-1-hildawu@realtek.com>
TO: Hilda Wu <hildawu@realtek.com>
TO: marcel@holtmann.org
CC: luiz.dentz@gmail.com
CC: linux-bluetooth@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: alex_lu@realsil.com.cn
CC: jason_mao@realsil.com.cn
CC: zoey_zhou@realsil.com.cn
CC: max.chou@realtek.com
CC: kidman@realtek.com
Hi Hilda,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v7.2 next-20260820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hilda-Wu/Bluetooth-btrtl-Add-firmware-format-v3-support/20260814-145920
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20260814065920.413487-1-hildawu%40realtek.com
patch subject: [PATCH v6] Bluetooth: btrtl: Add firmware format v3 support
:::::: branch date: 27 hours ago
:::::: commit date: 27 hours ago
config: x86_64-randconfig-161 (https://download.01.org/0day-ci/archive/20260822/202608221220.dvi7OT84-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202608221220.dvi7OT84-lkp@intel.com/
New smatch warnings:
drivers/bluetooth/btrtl.c:1106 btrtl_free() warn: variable dereferenced before check 'btrtl_dev' (see line 1098)
Old smatch warnings:
drivers/bluetooth/btrtl.c:1326 btrtl_initialize() warn: passing zero to 'ERR_PTR'
vim +/btrtl_dev +1106 drivers/bluetooth/btrtl.c
c0123cb6c4c7fc2 Vasily Khoruzhick 2023-03-07 1093
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1094 void btrtl_free(struct btrtl_device_info *btrtl_dev)
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1095 {
9a24ce5e29b15c4 Max Chou 2023-04-17 1096 struct rtl_subsection *entry, *tmp;
9a24ce5e29b15c4 Max Chou 2023-04-17 1097
268d3636dfb2225 Alice Mikityanska 2020-01-24 @1098 kvfree(btrtl_dev->fw_data);
268d3636dfb2225 Alice Mikityanska 2020-01-24 1099 kvfree(btrtl_dev->cfg_data);
9a24ce5e29b15c4 Max Chou 2023-04-17 1100
9a24ce5e29b15c4 Max Chou 2023-04-17 1101 list_for_each_entry_safe(entry, tmp, &btrtl_dev->patch_subsecs, list) {
9a24ce5e29b15c4 Max Chou 2023-04-17 1102 list_del(&entry->list);
9a24ce5e29b15c4 Max Chou 2023-04-17 1103 kfree(entry);
9a24ce5e29b15c4 Max Chou 2023-04-17 1104 }
9a24ce5e29b15c4 Max Chou 2023-04-17 1105
8e4d5e1dbe2345c Hilda Wu 2026-08-14 @1106 if (btrtl_dev) {
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1107 struct btrtl_enh_ops *ops = symbol_get(rtl_enh_ops);
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1108
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1109 if (ops) {
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1110 if (ops->free_patch_images)
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1111 ops->free_patch_images(btrtl_dev);
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1112 symbol_put(rtl_enh_ops);
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1113 }
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1114 }
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1115
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1116 kfree(btrtl_dev);
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1117 }
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1118 EXPORT_SYMBOL_GPL(btrtl_free);
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1119
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev, Hilda Wu <hildawu@realtek.com>,
marcel@holtmann.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org, alex_lu@realsil.com.cn,
jason_mao@realsil.com.cn, zoey_zhou@realsil.com.cn,
max.chou@realtek.com, kidman@realtek.com
Subject: Re: [PATCH v6] Bluetooth: btrtl: Add firmware format v3 support
Date: Sat, 22 Aug 2026 11:10:24 +0300 [thread overview]
Message-ID: <202608221220.dvi7OT84-lkp@intel.com> (raw)
In-Reply-To: <20260814065920.413487-1-hildawu@realtek.com>
Hi Hilda,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hilda-Wu/Bluetooth-btrtl-Add-firmware-format-v3-support/20260814-145920
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20260814065920.413487-1-hildawu%40realtek.com
patch subject: [PATCH v6] Bluetooth: btrtl: Add firmware format v3 support
config: x86_64-randconfig-161 (https://download.01.org/0day-ci/archive/20260822/202608221220.dvi7OT84-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202608221220.dvi7OT84-lkp@intel.com/
New smatch warnings:
drivers/bluetooth/btrtl.c:1106 btrtl_free() warn: variable dereferenced before check 'btrtl_dev' (see line 1098)
Old smatch warnings:
drivers/bluetooth/btrtl.c:1326 btrtl_initialize() warn: passing zero to 'ERR_PTR'
vim +/btrtl_dev +1106 drivers/bluetooth/btrtl.c
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1094 void btrtl_free(struct btrtl_device_info *btrtl_dev)
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1095 {
9a24ce5e29b15c4 Max Chou 2023-04-17 1096 struct rtl_subsection *entry, *tmp;
9a24ce5e29b15c4 Max Chou 2023-04-17 1097
268d3636dfb2225 Alice Mikityanska 2020-01-24 @1098 kvfree(btrtl_dev->fw_data);
268d3636dfb2225 Alice Mikityanska 2020-01-24 1099 kvfree(btrtl_dev->cfg_data);
9a24ce5e29b15c4 Max Chou 2023-04-17 1100
9a24ce5e29b15c4 Max Chou 2023-04-17 1101 list_for_each_entry_safe(entry, tmp, &btrtl_dev->patch_subsecs, list) {
9a24ce5e29b15c4 Max Chou 2023-04-17 1102 list_del(&entry->list);
9a24ce5e29b15c4 Max Chou 2023-04-17 1103 kfree(entry);
9a24ce5e29b15c4 Max Chou 2023-04-17 1104 }
9a24ce5e29b15c4 Max Chou 2023-04-17 1105
8e4d5e1dbe2345c Hilda Wu 2026-08-14 @1106 if (btrtl_dev) {
No point in checking for NULL when we have already dereferenced
btrtl_dev so many times.
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1107 struct btrtl_enh_ops *ops = symbol_get(rtl_enh_ops);
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1108
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1109 if (ops) {
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1110 if (ops->free_patch_images)
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1111 ops->free_patch_images(btrtl_dev);
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1112 symbol_put(rtl_enh_ops);
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1113 }
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1114 }
8e4d5e1dbe2345c Hilda Wu 2026-08-14 1115
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1116 kfree(btrtl_dev);
26503ad25de8c7c Martin Blumenstingl 2018-08-02 1117 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-08-22 4:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 4:27 kernel test robot [this message]
2026-08-22 8:10 ` [PATCH v6] Bluetooth: btrtl: Add firmware format v3 support Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2026-08-14 6:59 Hilda Wu
2026-08-14 8:37 ` [v6] " bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202608221220.dvi7OT84-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.