From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
stable@vger.kernel.org, vega@nebusec.ai,
"Victor Nogueira" <victor@mojatatu.com>
Subject: Re: [PATCH net 1/2] net/sched: pfifo_fast: cap ring size and account to memcg
Date: Sat, 22 Aug 2026 13:44:01 -0700 [thread overview]
Message-ID: <20260822134401.6545e4eb@kernel.org> (raw)
In-Reply-To: <20260820095742.68511-1-jhs@mojatatu.com>
On Thu, 20 Aug 2026 05:57:41 -0400 Jamal Hadi Salim wrote:
> + if (qlen > 65535) {
> + pr_warn_ratelimited("pfifo_fast: capping ring size %u to 65535 for dev %s\n",
> + qlen, qdisc_dev(qdisc)->name);
> + qlen = 65535;
> + }
Why not a hard cap? We do that all over the place, once in a release we
pick a value too small and someone quickly sends us a fix up to bump
the number. No problem.
next prev parent reply other threads:[~2026-08-22 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 9:57 [PATCH net 1/2] net/sched: pfifo_fast: cap ring size and account to memcg Jamal Hadi Salim
2026-08-20 9:57 ` [PATCH net 2/2] selftests: tc-testing: add pfifo_fast ring cap regression test Jamal Hadi Salim
2026-08-22 20:44 ` Jakub Kicinski [this message]
2026-08-22 22:14 ` [PATCH net 1/2] net/sched: pfifo_fast: cap ring size and account to memcg Jamal Hadi Salim
2026-08-22 23:02 ` Jakub Kicinski
2026-08-24 12:37 ` Jamal Hadi Salim
2026-08-25 16:08 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260822134401.6545e4eb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vega@nebusec.ai \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.