All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: gadget: f_phonet: fix out-of-bounds read in ifname_show
@ 2026-08-22  7:52 Alexander Bendezu
  2026-08-22  9:25 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Bendezu @ 2026-08-22  7:52 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Andrzej Pietrasiewicz, Felipe Balbi, linux-usb, linux-kernel,
	syzkaller-bugs, Alexander Bendezu, syzbot+3a0d6aa450317f25e501

The f_phonet_ifname_show() function incorrectly used gether_get_ifname(),
which casts the net_device private data to 'struct eth_dev'. Since the
Phonet gadget only allocates a small 'struct phonet_port' for its private
data, this resulted in a KASAN slab-out-of-bounds read when accessing
dev->ifname_set.

Fix this by safely reading the network device name directly using
netdev_name() and dropping the u_ether.h include, completely avoiding
the invalid struct cast.

Fixes: 0736390bea65 ("usb-gadget/f_phonet: use per-attribute show and store methods")
Reported-by: syzbot+3a0d6aa450317f25e501@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=3a0d6aa450317f25e501
Signed-off-by: Alexander Bendezu <alexanderbendezu10@gmail.com>
---
 drivers/usb/gadget/function/f_phonet.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_phonet.c b/drivers/usb/gadget/function/f_phonet.c
index b1ee9a7c2e94..a17e74bcc07c 100644
--- a/drivers/usb/gadget/function/f_phonet.c
+++ b/drivers/usb/gadget/function/f_phonet.c
@@ -13,6 +13,7 @@
 #include <linux/module.h>
 #include <linux/device.h>
 
+#include <linux/rtnetlink.h>
 #include <linux/netdevice.h>
 #include <linux/if_ether.h>
 #include <linux/if_phonet.h>
@@ -600,7 +601,13 @@ static const struct configfs_item_operations phonet_item_ops = {
 
 static ssize_t f_phonet_ifname_show(struct config_item *item, char *page)
 {
-	return gether_get_ifname(to_f_phonet_opts(item)->net, page, PAGE_SIZE);
+	struct net_device *net = to_f_phonet_opts(item)->net;
+	int ret;
+
+	rtnl_lock();
+	ret = scnprintf(page, PAGE_SIZE, "%s\n", netdev_name(net));
+	rtnl_unlock();
+	return ret;
 }
 
 CONFIGFS_ATTR_RO(f_phonet_, ifname);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-13  0:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-22  7:52 [PATCH] usb: gadget: f_phonet: fix out-of-bounds read in ifname_show Alexander Bendezu
2026-08-22  9:25 ` Greg Kroah-Hartman
2026-09-13  0:05   ` [PATCH v2] usb: gadget: f_phonet: don't call gether_get_ifname() on a non-u_ether netdev Alexander Bendezu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.