From: sashiko-bot@kernel.org
To: "Qi Zhang" <marsy12010123@gmail.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH net v2] net/smc: prevent device removal during connection setup
Date: Sun, 23 Aug 2026 07:30:34 +0000 [thread overview]
Message-ID: <20260823073035.34CB31F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260823071908.93212-1-marsy12010123@gmail.com>
> From: Chengfeng Ye <nicoyip.dev@gmail.com>
>
> smc_pnet_determine_gid() stores an smc_ib_device pointer in connection
> initialization data while holding smc_ib_devices.mutex. Connection setup
> keeps using the pointer after releasing the mutex, but device removal only
> waits for links which have already incremented lnk_cnt.
>
> This permits the following interleaving:
>
> connection setup device removal
> ---------------- --------------
> select smcibdev
> store ini->smcrv2.ib_dev_v2
> mutex_unlock()
> remove smcibdev from the device list
> [ ... ]
>
> Fixes: a046d57da19f ("smc: CLC handshake (incl. preparation steps)")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chengfeng Ye <nicoyip.dev@gmail.com>
> Signed-off-by: Qi Zhang <marsy12010123@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260823071908.93212-1-marsy12010123@gmail.com?part=1
next prev parent reply other threads:[~2026-08-23 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 7:19 [PATCH net v2] net/smc: prevent device removal during connection setup Qi Zhang
2026-08-23 7:30 ` sashiko-bot [this message]
2026-08-23 9:37 ` Markus Elfring
2026-08-26 9:11 ` Simon Horman
2026-08-27 18:00 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260823073035.34CB31F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=marsy12010123@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.