From: Simon Horman <horms@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Qi Zhang <marsy12010123@gmail.com>,
Chengfeng Ye <nicoyip.dev@gmail.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-s390@vger.kernel.org,
"D. Wythe" <alibuda@linux.alibaba.com>,
Dust Li <dust.li@linux.alibaba.com>,
Sidraya Jayagond <sidraya@linux.ibm.com>,
Mahanta Jambigi <mjambigi@linux.ibm.com>,
stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>
Subject: Re: [PATCH net v2] net/smc: prevent device removal during connection setup
Date: Wed, 26 Aug 2026 10:11:07 +0100 [thread overview]
Message-ID: <20260826091107.GA22033@horms.kernel.org> (raw)
In-Reply-To: <cfd7450e-0098-42e3-af4f-d5b47e842d23@web.de>
On Sun, Aug 23, 2026 at 11:37:17AM +0200, Markus Elfring wrote:
> …
> > This change is limited to the reported SMCR lifetime race. SMC-D device
> > selection has a similar pre-existing borrowed-pointer lifetime issue and
> > requires a separate fix.
>
> May lock guards be applied?
> https://elixir.bootlin.com/linux/v7.2/source/include/linux/mutex.h#L253
This approach seems fine to me.
Quoting the documentation:
Use of guard() is discouraged within any function longer than 20 lines,
scoped_guard() is considered more readable. Using normal lock/unlock is
still (weakly) preferred.
Link: https://docs.kernel.org/process/maintainer-netdev.html#using-device-managed-and-cleanup-h-constructs
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-08-26 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 7:19 [PATCH net v2] net/smc: prevent device removal during connection setup Qi Zhang
2026-08-23 7:30 ` sashiko-bot
2026-08-23 9:37 ` Markus Elfring
2026-08-26 9:11 ` Simon Horman [this message]
2026-08-27 18:00 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826091107.GA22033@horms.kernel.org \
--to=horms@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=marsy12010123@gmail.com \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicoyip.dev@gmail.com \
--cc=pabeni@redhat.com \
--cc=sidraya@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.