From: Rob Herring <robh@kernel.org>
To: GuoHan Zhao <zhaoguohan@kylinos.cn>
Cc: Tomeu Vizoso <tomeu@tomeuvizoso.net>,
dri-devel@lists.freedesktop.org, Oded Gabbay <ogabbay@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH v2 2/5] accel/ethosu: fix scheduler and IRQ lifetime
Date: Mon, 24 Aug 2026 17:06:54 -0500 [thread overview]
Message-ID: <20260824220654.GD50486-robh@kernel.org> (raw)
In-Reply-To: <20260717061145.1478139-3-zhaoguohan@kylinos.cn>
On Fri, Jul 17, 2026 at 02:11:42PM +0800, GuoHan Zhao wrote:
> ethosu_job_init() requests the managed IRQ before initializing the DRM
> scheduler. If drm_sched_init() fails, the error path calls drm_sched_fini()
> on a partially initialized scheduler. The IRQ also remains registered until
> devres cleanup after normal or probe-error paths destroy the scheduler.
>
> Initialize the scheduler before requesting the IRQ. Scheduler setup failure
> then needs no teardown, while IRQ setup failure can tear down a valid
> scheduler. Free the IRQ explicitly before drm_sched_fini() to prevent
> interrupt handlers from accessing scheduler state during teardown.
I don't think there's an actual issue here. The interrupt is never going
to fire unless probe successfully completes because we reset the h/w and
the interrupt only fires if we schedule something on it.
Rob
next prev parent reply other threads:[~2026-08-24 22:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 6:11 [PATCH v2 0/5] accel/ethosu: fix probe and job cleanup errors GuoHan Zhao
2026-07-17 6:11 ` [PATCH v2 1/5] accel/ethosu: check DMA mask setup GuoHan Zhao
2026-07-17 6:23 ` sashiko-bot
2026-08-24 21:58 ` Rob Herring
2026-07-17 6:11 ` [PATCH v2 2/5] accel/ethosu: fix scheduler and IRQ lifetime GuoHan Zhao
2026-07-17 6:24 ` sashiko-bot
2026-08-24 22:06 ` Rob Herring [this message]
2026-07-17 6:11 ` [PATCH v2 3/5] accel/ethosu: clean up resources on probe failure GuoHan Zhao
2026-07-17 6:27 ` sashiko-bot
2026-07-17 6:11 ` [PATCH v2 4/5] accel/ethosu: propagate SRAM initialization errors GuoHan Zhao
2026-07-17 6:24 ` sashiko-bot
2026-08-25 0:53 ` Rob Herring
2026-07-17 6:11 ` [PATCH v2 5/5] accel/ethosu: fix job completion fence cleanup GuoHan Zhao
2026-07-17 6:22 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824220654.GD50486-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ogabbay@kernel.org \
--cc=tomeu@tomeuvizoso.net \
--cc=tzimmermann@suse.de \
--cc=zhaoguohan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.