From: Rob Herring <robh@kernel.org>
To: GuoHan Zhao <zhaoguohan@kylinos.cn>
Cc: Tomeu Vizoso <tomeu@tomeuvizoso.net>,
dri-devel@lists.freedesktop.org, Oded Gabbay <ogabbay@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH v2 4/5] accel/ethosu: propagate SRAM initialization errors
Date: Mon, 24 Aug 2026 19:53:41 -0500 [thread overview]
Message-ID: <20260825005341.GF50486-robh@kernel.org> (raw)
In-Reply-To: <20260717061145.1478139-5-zhaoguohan@kylinos.cn>
On Fri, Jul 17, 2026 at 02:11:44PM +0800, GuoHan Zhao wrote:
> ethosu_sram_init() returns -ENOMEM if allocation from a declared SRAM
> pool fails. ethosu_init() ignores the error after recording the pool size.
> Probe then registers a device with a nonzero SRAM size and a zero sramphys
> address, allowing jobs to program address zero for SRAM.
>
> Propagate the error and synchronously suspend the device before the probe
> path releases the scheduler.
If the SRAM is not available for some reason, then we should just set
the SRAM size reported to 0 rather than failing probe.
Rob
next prev parent reply other threads:[~2026-08-25 0:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 6:11 [PATCH v2 0/5] accel/ethosu: fix probe and job cleanup errors GuoHan Zhao
2026-07-17 6:11 ` [PATCH v2 1/5] accel/ethosu: check DMA mask setup GuoHan Zhao
2026-07-17 6:23 ` sashiko-bot
2026-08-24 21:58 ` Rob Herring
2026-07-17 6:11 ` [PATCH v2 2/5] accel/ethosu: fix scheduler and IRQ lifetime GuoHan Zhao
2026-07-17 6:24 ` sashiko-bot
2026-08-24 22:06 ` Rob Herring
2026-07-17 6:11 ` [PATCH v2 3/5] accel/ethosu: clean up resources on probe failure GuoHan Zhao
2026-07-17 6:27 ` sashiko-bot
2026-07-17 6:11 ` [PATCH v2 4/5] accel/ethosu: propagate SRAM initialization errors GuoHan Zhao
2026-07-17 6:24 ` sashiko-bot
2026-08-25 0:53 ` Rob Herring [this message]
2026-07-17 6:11 ` [PATCH v2 5/5] accel/ethosu: fix job completion fence cleanup GuoHan Zhao
2026-07-17 6:22 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825005341.GF50486-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ogabbay@kernel.org \
--cc=tomeu@tomeuvizoso.net \
--cc=tzimmermann@suse.de \
--cc=zhaoguohan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.