From: Eric Biggers <ebiggers@kernel.org>
To: Ayush Singh <ayush@beagleboard.org>
Cc: "Jason Kridner" <jkridner@beagleboard.org>,
robertcnelson@gmail.com, "Johan Hovold" <johan@kernel.org>,
"Alex Elder" <elder@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Ayush Singh" <ayush@beagleboard.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/7] rust: crc_ccitt: add CRC-CCITT abstraction
Date: Tue, 25 Aug 2026 17:56:25 +0000 [thread overview]
Message-ID: <20260825175625.GA3673306@google.com> (raw)
In-Reply-To: <93977935-ea60-48de-9d13-23454e038c18@beagleboard.org>
On Fri, Aug 21, 2026 at 10:55:41AM +0530, Ayush Singh wrote:
> > > diff --git a/rust/kernel/crc_ccitt.rs b/rust/kernel/crc_ccitt.rs
> > > new file mode 100644
> > > index 000000000000..6042ada16967
> > > --- /dev/null
> > > +++ b/rust/kernel/crc_ccitt.rs
> > Is there a reason why the kconfig symbol is being put in lib/crc/ but
> > the actual code is being put in rust/kernel/? It seems inconsistent.
> >
> > - Eric
>
>
> Was copying `RUST_SERIAL_DEV_BUS_ABSTRACTIONS`. It is also in
> `drivers/tty/serdev/Kconfig`.
kconfig options usually should be in the same directory as the code they
control.
- Eric
next prev parent reply other threads:[~2026-08-25 17:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 9:25 [PATCH 0/7] Add Greybus Sotfsvc and UART Node drivers Ayush Singh
2026-08-20 9:25 ` [PATCH 1/7] greybus: connection: Export gb_connection_get() and gb_connection_put() Ayush Singh
2026-08-20 9:41 ` sashiko-bot
2026-08-20 9:25 ` [PATCH 2/7] greybus: connection: Add gb_connection_hd_find_by_intf() Ayush Singh
2026-08-20 9:32 ` sashiko-bot
2026-08-20 9:25 ` [PATCH 3/7] rust: crc_ccitt: add CRC-CCITT abstraction Ayush Singh
2026-08-20 9:33 ` sashiko-bot
2026-08-21 3:00 ` Eric Biggers
2026-08-21 5:25 ` Ayush Singh
2026-08-25 17:56 ` Eric Biggers [this message]
2026-08-25 19:20 ` Miguel Ojeda
2026-08-20 9:25 ` [PATCH 4/7] rust: kernel: Add greybus abstractions Ayush Singh
2026-08-20 9:42 ` sashiko-bot
2026-08-20 9:25 ` [PATCH 5/7] drivers: greybus: Add software SVC implementation Ayush Singh
2026-08-20 9:40 ` sashiko-bot
2026-08-20 9:25 ` [PATCH 6/7] greybus: Add Rust UART node driver Ayush Singh
2026-08-20 9:38 ` sashiko-bot
2026-08-20 9:25 ` [PATCH 7/7] dt-bindings: beagle: Add BeagleConnect Freedom Ayush Singh
2026-08-20 9:31 ` sashiko-bot
2026-08-20 18:33 ` Conor Dooley
2026-08-21 5:31 ` Ayush Singh
2026-08-21 17:20 ` Conor Dooley
2026-08-21 6:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825175625.GA3673306@google.com \
--to=ebiggers@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=ardb@kernel.org \
--cc=ayush@beagleboard.com \
--cc=ayush@beagleboard.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jkridner@beagleboard.org \
--cc=johan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.