From: Yixun Lan <dlan@kernel.org>
To: Bruno Banelli <bbanelli@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Ze Huang <huang.ze@linux.dev>, Alex Elder <elder@riscstar.com>,
linux-phy@lists.infradead.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] phy: spacemit: fix and enable the K1 USB 2.0 PHY
Date: Tue, 25 Aug 2026 23:07:24 +0000 [thread overview]
Message-ID: <20260825230724-GKF631715@kernel.org> (raw)
In-Reply-To: <20260825065007.69353-1-bbanelli@gmail.com>
Hi Bruno,
On 08:50 Tue 25 Aug , Bruno Banelli wrote:
> v1 was a single patch adding "default ARCH_SPACEMIT" to
> PHY_SPACEMIT_K1_USB2. Automated review pointed out two pre-existing
> Kconfig problems in the same entry, and that change makes them easier
> to hit: enabling the symbol by default means configurations that would
> previously have left it off will now build the driver.
>
> So fix the dependencies first, then enable it by default.
>
> Both were verified against the driver source: phy-k1-usb2.c calls
> devm_platform_ioremap_resource() and devm_regmap_init_mmio(), while the
> Kconfig entry has neither "depends on HAS_IOMEM" nor
> "select REGMAP_MMIO". PHY_SPACEMIT_K1_PCIE, directly above it in the
> same file, already has the HAS_IOMEM dependency.
>
> Tested on a Milk-V Jupiter (SpacemiT M1) running mainline 7.2: without
> patch 2/2 a "make defconfig" kernel has no USB at all, because
> dwc3-generic-plat cannot get its PHY.
>
> v1: https://lore.kernel.org/linux-riscv/20260825052158.66367-1-bbanelli@gmail.com/
>
> Changes in v2:
> - new patch 1/2 adding "depends on HAS_IOMEM" and "select REGMAP_MMIO",
> with a Fixes: tag
> - no change to the patch now numbered 2/2
>
Thanks for this v2
Reviewed-by: Yixun Lan <dlan@kernel.org>
--
Yixun Lan (dlan)
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Bruno Banelli <bbanelli@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Ze Huang <huang.ze@linux.dev>, Alex Elder <elder@riscstar.com>,
linux-phy@lists.infradead.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] phy: spacemit: fix and enable the K1 USB 2.0 PHY
Date: Tue, 25 Aug 2026 23:07:24 +0000 [thread overview]
Message-ID: <20260825230724-GKF631715@kernel.org> (raw)
In-Reply-To: <20260825065007.69353-1-bbanelli@gmail.com>
Hi Bruno,
On 08:50 Tue 25 Aug , Bruno Banelli wrote:
> v1 was a single patch adding "default ARCH_SPACEMIT" to
> PHY_SPACEMIT_K1_USB2. Automated review pointed out two pre-existing
> Kconfig problems in the same entry, and that change makes them easier
> to hit: enabling the symbol by default means configurations that would
> previously have left it off will now build the driver.
>
> So fix the dependencies first, then enable it by default.
>
> Both were verified against the driver source: phy-k1-usb2.c calls
> devm_platform_ioremap_resource() and devm_regmap_init_mmio(), while the
> Kconfig entry has neither "depends on HAS_IOMEM" nor
> "select REGMAP_MMIO". PHY_SPACEMIT_K1_PCIE, directly above it in the
> same file, already has the HAS_IOMEM dependency.
>
> Tested on a Milk-V Jupiter (SpacemiT M1) running mainline 7.2: without
> patch 2/2 a "make defconfig" kernel has no USB at all, because
> dwc3-generic-plat cannot get its PHY.
>
> v1: https://lore.kernel.org/linux-riscv/20260825052158.66367-1-bbanelli@gmail.com/
>
> Changes in v2:
> - new patch 1/2 adding "depends on HAS_IOMEM" and "select REGMAP_MMIO",
> with a Fixes: tag
> - no change to the patch now numbered 2/2
>
Thanks for this v2
Reviewed-by: Yixun Lan <dlan@kernel.org>
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Bruno Banelli <bbanelli@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Ze Huang <huang.ze@linux.dev>, Alex Elder <elder@riscstar.com>,
linux-phy@lists.infradead.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] phy: spacemit: fix and enable the K1 USB 2.0 PHY
Date: Tue, 25 Aug 2026 23:07:24 +0000 [thread overview]
Message-ID: <20260825230724-GKF631715@kernel.org> (raw)
In-Reply-To: <20260825065007.69353-1-bbanelli@gmail.com>
Hi Bruno,
On 08:50 Tue 25 Aug , Bruno Banelli wrote:
> v1 was a single patch adding "default ARCH_SPACEMIT" to
> PHY_SPACEMIT_K1_USB2. Automated review pointed out two pre-existing
> Kconfig problems in the same entry, and that change makes them easier
> to hit: enabling the symbol by default means configurations that would
> previously have left it off will now build the driver.
>
> So fix the dependencies first, then enable it by default.
>
> Both were verified against the driver source: phy-k1-usb2.c calls
> devm_platform_ioremap_resource() and devm_regmap_init_mmio(), while the
> Kconfig entry has neither "depends on HAS_IOMEM" nor
> "select REGMAP_MMIO". PHY_SPACEMIT_K1_PCIE, directly above it in the
> same file, already has the HAS_IOMEM dependency.
>
> Tested on a Milk-V Jupiter (SpacemiT M1) running mainline 7.2: without
> patch 2/2 a "make defconfig" kernel has no USB at all, because
> dwc3-generic-plat cannot get its PHY.
>
> v1: https://lore.kernel.org/linux-riscv/20260825052158.66367-1-bbanelli@gmail.com/
>
> Changes in v2:
> - new patch 1/2 adding "depends on HAS_IOMEM" and "select REGMAP_MMIO",
> with a Fixes: tag
> - no change to the patch now numbered 2/2
>
Thanks for this v2
Reviewed-by: Yixun Lan <dlan@kernel.org>
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-08-25 23:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 6:50 [PATCH v2 0/2] phy: spacemit: fix and enable the K1 USB 2.0 PHY Bruno Banelli
2026-08-25 6:50 ` Bruno Banelli
2026-08-25 6:50 ` Bruno Banelli
2026-08-25 6:50 ` [PATCH v2 1/2] phy: spacemit: fix K1 USB 2.0 PHY Kconfig dependencies Bruno Banelli
2026-08-25 6:50 ` Bruno Banelli
2026-08-25 6:50 ` Bruno Banelli
2026-08-25 6:50 ` [PATCH v2 2/2] phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT Bruno Banelli
2026-08-25 6:50 ` Bruno Banelli
2026-08-25 6:50 ` Bruno Banelli
2026-08-25 7:03 ` sashiko-bot
2026-08-25 23:07 ` Yixun Lan [this message]
2026-08-25 23:07 ` [PATCH v2 0/2] phy: spacemit: fix and enable the K1 USB 2.0 PHY Yixun Lan
2026-08-25 23:07 ` Yixun Lan
2026-10-03 15:25 ` Vinod Koul
2026-10-03 15:25 ` Vinod Koul
2026-10-03 15:25 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825230724-GKF631715@kernel.org \
--to=dlan@kernel.org \
--cc=bbanelli@gmail.com \
--cc=elder@riscstar.com \
--cc=huang.ze@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=spacemit@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.