[f2fs-dev] [PATCH] f2fs: force out-place update for all writes on compressed file

[Jiucheng Xu via B4 Relay via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>]

From: Jiucheng Xu <jiucheng.xu@amlogic.com>

For compressed file, compressed write may fail and fall back to raw
write.
If in-place update(IPU) is allowed, raw data could be written into disk
before cluster metadata is updated from compressed state to raw state.
Sudden power-cut during this window will result in inconsistency:
raw data on disk but metadata still expects compressed content,
which causes decompression failure when reading the file later.

To eliminate this risk completely, force out-place update for all
write operations on compressed file, so IPU will never be used.

Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
---
 fs/f2fs/data.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 6ae0eb37d20f96ed51a8124f59ba90dabf632fb5..aaeea561dcd30681b9b37f2f6f0493ed58ec2fe0 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -2973,10 +2973,12 @@ bool f2fs_should_update_outplace(struct inode *inode, struct f2fs_io_info *fio)
 		return true;
 	if (f2fs_used_in_atomic_write(inode))
 		return true;
-	/* rewrite low ratio compress data w/ OPU mode to avoid fragmentation */
-	if (f2fs_compressed_file(inode) &&
-		F2FS_OPTION(sbi).compress_mode == COMPR_MODE_USER &&
-		is_inode_flag_set(inode, FI_ENABLE_COMPRESS))
+	/*
+	 * rewrite low ratio compress data w/ OPU mode to avoid fragmentation.
+	 * If IO comes from compressed write path and fallback to raw write,
+	 * force out‑place to prevent metadata‑data inconsistency.
+	 */
+	if (f2fs_compressed_file(inode))
 		return true;
 
 	/* swap file is migrating in aligned write mode */

---
base-commit: 0a1703eba23707e3b2edfa2a2329352e7abc0ffa
change-id: 20260818-origin-dev-0e8c63e2145a

Best regards,
-- 
Jiucheng Xu <jiucheng.xu@amlogic.com>




_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel