Re: [PATCH v5 01/10] dtc: dt-check-style: Handle sorting of top-level nodes and properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Strict string equality check for root node overlays fails on variable whitespace.
--

commit f8f70e68a9d636c397e92564f4d820f3585db82c
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Handle sorting of top-level nodes and properties

Top-level DTS has two nodes with unit-addresses (memory@ and soc@) where
sorting typically prefers node name over unit address. This patch updates
the style checker to apply special sorting rules for the root node,
including placing the model property before compatible.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 96deffc0d8a7c..e5f26d3e2792b 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
[ ... ]
> @@ -228,7 +230,10 @@ def classify_lines(text):
>              continue
>  
>          if code.endswith('{'):
> -            dl = DtsLine(i, raw, LineType.NODE_OPEN, depth, indent_str, code)
> +            is_root = False
> +            if code == '&{/} {' or re.search(r'^/\s*\{$', code):

[Severity: Medium]
Will this strict string equality check fail to identify root node overlays if
there is any variation in whitespace before the opening brace, such as
&{/}{ or &{/}  {?

If this fails to identify them as root nodes, does the script fall back to
standard node rules and incorrectly produce false positive style warnings
for root node overlays?

> +                is_root = True
> +            dl = DtsLine(i, raw, LineType.NODE_OPEN, depth, indent_str, code, is_root=is_root)
>              parse_node_header(dl)
>              out.append(dl)
>              depth += 1
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-n-dts-style-checker-continued-v5-0-fdd16ca6e771@oss.qualcomm.com?part=1