Re: [PATCH v5 07/10] dtc: dt-check-style: Call _strip_strings_and_comments() only once

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removal of `.strip()` in check_value_whitespace introduces false positive warnings for extra whitespace.
--

commit f4faff4b08497467646cdf648bcdf86e75cfd546
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Call _strip_strings_and_comments() only once
    
More than one rule evaluates pure code - stripped from comments and
indentation - thus store this pure code in DtsLine class for
better performance.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index a1034f6b9cafd..da7edd5ea079d 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style

[ ... ]

> @@ -860,9 +860,9 @@ def check_value_whitespace(ctx):
>      for dl in ctx.lines:
>          if dl.linetype != LineType.PROPERTY:
>              continue
> -        segs = [_strip_strings_and_comments(dl.raw).strip()]
> +        segs = [dl.code]
>          for cont in dl.continuations:
> -            segs.append(_strip_strings_and_comments(cont.stripped).strip())
> +            segs.append(cont.code)

[Severity: Medium]
Does removing .strip() here introduce false positive warnings for extra
whitespace?

When an inline block comment is removed from a continuation line (for example
"/* comment */ 1>;"), the leading space is left behind. Without .strip(),
this space is preserved when the property segments are concatenated. This
could falsely trigger the strict mode regex match for extra whitespace inside
brackets.

>          text = ''
>          for s in segs:
>              if not s:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-n-dts-style-checker-continued-v5-0-fdd16ca6e771@oss.qualcomm.com?part=7