[LTP] [PATCH v4 12/31] testcases: sysfs: Add sys_ata01

[Cyril Hrubis <chrubis@suse.cz>]

A test for /sys/class/ata_device/*/* files.

Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 include/tst_path_defs.h                       |   3 +
 runtest/sysfs                                 |   1 +
 testcases/kernel/sysfs/class/Makefile         |   7 ++
 .../kernel/sysfs/class/ata_device/.gitignore  |   1 +
 .../kernel/sysfs/class/ata_device/Makefile    |   7 ++
 .../kernel/sysfs/class/ata_device/sys_ata01.c | 100 ++++++++++++++++++
 6 files changed, 119 insertions(+)
 create mode 100644 testcases/kernel/sysfs/class/Makefile
 create mode 100644 testcases/kernel/sysfs/class/ata_device/.gitignore
 create mode 100644 testcases/kernel/sysfs/class/ata_device/Makefile
 create mode 100644 testcases/kernel/sysfs/class/ata_device/sys_ata01.c

diff --git a/include/tst_path_defs.h b/include/tst_path_defs.h
index 4c25c796a..94c4a65bc 100644
--- a/include/tst_path_defs.h
+++ b/include/tst_path_defs.h
@@ -92,6 +92,9 @@
 #define MEMINFO_HPAGE_SURP	"HugePages_Surp:"
 #define MEMINFO_HPAGE_SIZE	"Hugepagesize:"
 
+/* SYSFS CLASS */
+#define PATH_CLASS_ATA_DEVICE			"/sys/class/ata_device"
+
 /* SYSFS DEVICES */
 #define PATH_SYS_CLOCKEVENTS			"/sys/devices/system/clockevents"
 #define PATH_SYS_CLOCKSOURCE			"/sys/devices/system/clocksource"
diff --git a/runtest/sysfs b/runtest/sysfs
index 3015c03f5..b5e644237 100644
--- a/runtest/sysfs
+++ b/runtest/sysfs
@@ -8,3 +8,4 @@ sys_cpu_vulnerabilities01 sys_cpu_vulnerabilities01
 sys_cpu_smt01 sys_cpu_smt01
 sys_cpu_cache01 sys_cpu_cache01
 sys_clockevents01 sys_clockevents01
+sys_ata01 sys_ata01
diff --git a/testcases/kernel/sysfs/class/Makefile b/testcases/kernel/sysfs/class/Makefile
new file mode 100644
index 000000000..5c8e7a249
--- /dev/null
+++ b/testcases/kernel/sysfs/class/Makefile
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (c) 2026 Cyril Hrubis <chrubis@suse.cz>
+
+top_srcdir		?= ../../../..
+
+include $(top_srcdir)/include/mk/env_pre.mk
+include $(top_srcdir)/include/mk/generic_trunk_target.mk
diff --git a/testcases/kernel/sysfs/class/ata_device/.gitignore b/testcases/kernel/sysfs/class/ata_device/.gitignore
new file mode 100644
index 000000000..b5b1f8f4a
--- /dev/null
+++ b/testcases/kernel/sysfs/class/ata_device/.gitignore
@@ -0,0 +1 @@
+/sys_ata01
diff --git a/testcases/kernel/sysfs/class/ata_device/Makefile b/testcases/kernel/sysfs/class/ata_device/Makefile
new file mode 100644
index 000000000..034038061
--- /dev/null
+++ b/testcases/kernel/sysfs/class/ata_device/Makefile
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (c) 2026 Cyril Hrubis <chrubis@suse.cz>
+
+top_srcdir		?= ../../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/sysfs/class/ata_device/sys_ata01.c b/testcases/kernel/sysfs/class/ata_device/sys_ata01.c
new file mode 100644
index 000000000..21e58105c
--- /dev/null
+++ b/testcases/kernel/sysfs/class/ata_device/sys_ata01.c
@@ -0,0 +1,100 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2026 Cyril Hrubis <chrubis@suse.cz>
+ */
+
+/*\
+ * Sanity checks for the ATA device attributes exported under
+ * /sys/class/ata_device/<dev>/.
+ *
+ * For every ATA device the test verifies that:
+ *
+ * - class is one of the known libata device classes (ata, atapi, pmp, semb,
+ *   unknown, zac, none). none is a legitimate value here, not just a range
+ *   extension for safety: ata_tdev_add() in drivers/ata/libata-transport.c
+ *   creates a transport device object for every possible device slot on a
+ *   link (e.g. both the master/slave slots on a PATA link), regardless of
+ *   whether a physical device is actually attached to it, so an empty slot
+ *   reports class = none rather than not existing at all.
+ * - dma_mode, pio_mode and xfer_mode, when non-empty, start with the
+ *   ``XFER_`` prefix used by all libata transfer mode names
+ * - spdn_cnt (speed-down count) is non-negative
+ *
+ * dma_mode is legitimately empty for devices that only support PIO, so it is
+ * only checked when present.
+ *
+ * The test skips with TCONF when no ATA device is present.
+ */
+
+#include <string.h>
+#include <dirent.h>
+#include "tst_test.h"
+#include "tst_sysfs_assert.h"
+#include "tst_path_defs.h"
+
+static const char *const class_allowed[] = {
+	"ata", "atapi", "pmp", "semb", "unknown", "zac", "none", NULL
+};
+
+static void check_mode(const char *dev, const char *attr)
+{
+	char mode[32];
+
+	if (!TST_SYSFS_READ_STR(mode, sizeof(mode),
+				PATH_CLASS_ATA_DEVICE "/%s/%s", dev, attr)) {
+		tst_res(TCONF, "%s/%s does not exist", dev, attr);
+		return;
+	}
+
+	if (mode[0] == '\0') {
+		tst_res(TCONF, "%s/%s is empty", dev, attr);
+		return;
+	}
+
+	if (!strncmp(mode, "XFER_", 5))
+		tst_res(TPASS, "%s/%s = '%s'", dev, attr, mode);
+	else
+		tst_res(TFAIL, "%s/%s = '%s' has no XFER_ prefix",
+			dev, attr, mode);
+}
+
+static void check_device(const char *dev)
+{
+	tst_res(TINFO, "Checking ata device '%s'", dev);
+
+	TST_SYSFS_ASSERT_ONEOF(class_allowed, PATH_CLASS_ATA_DEVICE "/%s/class", dev);
+	check_mode(dev, "dma_mode");
+	check_mode(dev, "pio_mode");
+	check_mode(dev, "xfer_mode");
+
+	TST_SYSFS_ASSERT_RANGELL(0, LONG_MAX, PATH_CLASS_ATA_DEVICE "/%s/spdn_cnt", dev);
+}
+
+static void do_test(void)
+{
+	DIR *d;
+	struct dirent *ent;
+	int found = 0;
+
+	if (!tst_sysfs_exists(PATH_CLASS_ATA_DEVICE))
+		tst_brk(TCONF, PATH_CLASS_ATA_DEVICE ": not present");
+
+	d = SAFE_OPENDIR(PATH_CLASS_ATA_DEVICE);
+
+	while ((ent = SAFE_READDIR(d))) {
+		if (ent->d_name[0] == '.')
+			continue;
+
+		found = 1;
+		check_device(ent->d_name);
+	}
+
+	SAFE_CLOSEDIR(d);
+
+	if (!found)
+		tst_res(TCONF, "No ATA device found");
+}
+
+static struct tst_test test = {
+	.test_all = do_test,
+};
-- 
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp