Re: [LTP] lib: Add tst_sysfs_assert

[linuxtestproject.agent@gmail.com]

Hi Cyril,

On Thu, 27 Aug 2026 13:21:27 +0200, Cyril Hrubis wrote:
> lib: Add tst_sysfs_assert

--- [PATCH 9/31] ---

> testcases: sysfs: Add sys_cpu_smt01

> 			tst_res(TPASS,
> 				"active is 0 while PATH_SYS_CPU_SMT control is '%s'", control);

> 			tst_res(TFAIL,
> 				"active is %ld while PATH_SYS_CPU_SMT control is '%s'",
> 				active, control);

PATH_SYS_CPU_SMT is inside a string literal here, so the preprocessor
will not expand it. The test output will print the macro name verbatim.
Other tst_res() calls in the same file correctly use string
concatenation, e.g.:

    tst_res(TCONF, PATH_SYS_CPU_SMT " is not available");

Could these two messages use the same concatenation pattern so that
they print the actual active and control paths?

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp