* [to-be-updated] zram-fix-idle-age_sec-underflow-in-idle_store.patch removed from -mm tree
@ 2026-08-28 5:57 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-08-28 5:57 UTC (permalink / raw)
To: mm-commits, stable, senozhatsky, minchan, axboe, jiahao1, akpm
The quilt patch titled
Subject: zram: fix idle age_sec underflow in idle_store()
has been removed from the -mm tree. Its filename was
zram-fix-idle-age_sec-underflow-in-idle_store.patch
This patch was dropped because an updated version will be issued
------------------------------------------------------
From: Hao Jia <jiahao1@lixiang.com>
Subject: zram: fix idle age_sec underflow in idle_store()
Date: Tue, 25 Aug 2026 17:23:16 +0800
After commit 2e8ff2f51dde ("zram: use u32 for entry ac_time tracking"),
idle_store() computes the idle cutoff as follows:
cutoff = ktime_sub((u32)ktime_get_boottime_seconds(), age_sec);
Because the left operand is cast to a 32-bit unsigned integer, when
age_sec exceeds the current uptime, the subtraction wraps modulo 2^32 and
the huge result is zero-extended into the s64 cutoff. mark_idle()
subsequently marks every entry as idle instead of matching nothing,
breaking the intended semantics of /sys/block/zramX/idle. For instance,
running echo 86400 > idle on a machine up for only two minutes causes all
newly written pages to be marked as idle and handed over to idle writeback
and recompression.
Drop the explicit cast to perform the subtraction in signed arithmetic
again, restoring the previous behavior: an age_sec greater than uptime
yields a negative cutoff, and one equal to uptime yields 0. Since a
cutoff of 0 is now a valid computed value, it can no longer double as the
"all" sentinel. Switch to KTIME_MIN instead, which no ac_time can be
after.
Link: https://lore.kernel.org/20260825092316.69658-1-jiahao.kernel@gmail.com
Fixes: 2e8ff2f51dde ("zram: use u32 for entry ac_time tracking")
Signed-off-by: Hao Jia <jiahao1@lixiang.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/block/zram/zram_drv.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/block/zram/zram_drv.c~zram-fix-idle-age_sec-underflow-in-idle_store
+++ a/drivers/block/zram/zram_drv.c
@@ -438,7 +438,7 @@ static void mark_idle(struct zram *zram,
}
#ifdef CONFIG_ZRAM_TRACK_ENTRY_ACTIME
- is_idle = !cutoff ||
+ is_idle = cutoff == KTIME_MIN ||
ktime_after(cutoff, zram->table[index].attr.ac_time);
#endif
if (is_idle)
@@ -453,7 +453,7 @@ static ssize_t idle_store(struct device
const char *buf, size_t len)
{
struct zram *zram = dev_to_zram(dev);
- ktime_t cutoff = 0;
+ ktime_t cutoff = KTIME_MIN;
if (!sysfs_streq(buf, "all")) {
/*
@@ -464,7 +464,7 @@ static ssize_t idle_store(struct device
if (IS_ENABLED(CONFIG_ZRAM_TRACK_ENTRY_ACTIME) &&
!kstrtouint(buf, 0, &age_sec))
- cutoff = ktime_sub((u32)ktime_get_boottime_seconds(),
+ cutoff = ktime_sub(ktime_get_boottime_seconds(),
age_sec);
else
return -EINVAL;
@@ -475,7 +475,7 @@ static ssize_t idle_store(struct device
return -EINVAL;
/*
- * A cutoff of 0 marks everything as idle, this is the
+ * A cutoff of KTIME_MIN marks everything as idle, this is the
* "all" behavior.
*/
mark_idle(zram, cutoff);
_
Patches currently in -mm which might be from jiahao1@lixiang.com are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-28 5:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-28 5:57 [to-be-updated] zram-fix-idle-age_sec-underflow-in-idle_store.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.