Re: [PATCH v3 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect use of `additionalProperties: false` with a top-level `$ref`, which blocks inherited common properties.
--

commit 065f027b1ff1efb3cf1642216e2b0f54de8f7f54
Author: Lachlan Michael <lachlan.michael@sony.com>

media: dt-bindings: imx908: Add Sony IMX908 sensor

The Sony IMX908 is an 8.39 megapixel (3856x2176) CMOS image sensor
with a MIPI CSI-2 output interface, supporting RAW10 and RAW12 output
over 2 or 4 data lanes. Add device tree bindings for the sensor.

> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> new file mode 100644
> index 0000000000000..828db1175e2f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> @@ -0,0 +1,108 @@
[ ... ]
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - dvdd-supply
> +  - ovdd-supply
> +  - avdd-supply
> +  - port
> +
> +additionalProperties: false

[Severity: Low]
Will this incorrectly reject valid device tree properties inherited from
video-interface-devices.yaml?

Since there is a top-level reference to video-interface-devices.yaml, using
additionalProperties here forbids common media properties like rotation,
orientation, or lens-focus from being evaluated. This will cause make
dtbs_check to fail if those properties are present in the device tree.

Should this be unevaluatedProperties: false instead?

> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828064843.65047-1-lachlan.michael@sony.com?part=1