Re: [PATCH v3 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Lachlan,

Thank you for the patch.

On Fri, Aug 28, 2026 at 03:48:42PM +0900, Lachlan Michael wrote:
> The Sony IMX908 is an 8.39 megapixel (3856x2176) CMOS image sensor
> with a MIPI CSI-2 output interface, supporting RAW10 and RAW12 output
> over 2 or 4 data lanes.
> 
> Add device tree bindings for the sensor.
> 
> Signed-off-by: Lachlan Michael <lachlan.michael@sony.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Changes in v3:
> -  Adjust the binding description to match the actual hardware: the I2C
>    target address is selected by the SLAMODE pins, not fixed to 0x1A.
> -  Add the standard video-interface schema reference so the endpoint and
>    remote-endpoint validation match the media DT conventions.
> ---
>  .../bindings/media/i2c/sony,imx908.yaml       | 108 ++++++++++++++++++
>  MAINTAINERS                                   |   5 +
>  2 files changed, 113 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> new file mode 100644
> index 000000000000..828db1175e2f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> @@ -0,0 +1,108 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2026 Sony Semiconductor Solutions
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/sony,imx908.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony IMX908 CMOS Image Sensor
> +
> +maintainers:
> +  - Lachlan Michael <Lachlan.Michael@sony.com>
> +
> +description:
> +  Sony IMX908 diagonal 6.42 mm (Type 1/2.8) CMOS active pixel type
> +  solid-state image sensor with a square pixel array and 8.39 M
> +  (3856x2176) pixels, supporting MIPI CSI-2 output with
> +  RAW10 and RAW12 formats, configured as either 2 or 4 data lanes.
> +  The I2C target address is selected by the SLAMODE0 and SLAMODE1 pins.
> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: sony,imx908
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    description: Input clock (24 MHz, 27 MHz, 37.125 MHz, 72 MHz or 74.25 MHz)
> +    maxItems: 1
> +
> +  dvdd-supply:
> +    description: Digital supply voltage (1.1V)
> +
> +  ovdd-supply:
> +    description: Interface supply voltage (1.8V)
> +
> +  avdd-supply:
> +    description: Analog supply voltage (3.3V)
> +
> +  reset-gpios:
> +    description: Sensor reset (XCLR) GPIO. Active low.
> +    maxItems: 1
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    unevaluatedProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            oneOf:
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +                  - const: 4
> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - dvdd-supply
> +  - ovdd-supply
> +  - avdd-supply
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +         camera@1a {
> +            compatible = "sony,imx908";
> +            reg = <0x1a>;
> +            clocks = <&cdce913_cam0 0>;
> +            dvdd-supply = <&cam_dvdd_1r1v>;
> +            ovdd-supply = <&cam_ovdd_1r8v>;
> +            avdd-supply = <&cam_avdd_3r3v>;
> +            reset-gpios = <&tca6416_cam0 5 GPIO_ACTIVE_LOW>;
> +
> +            port {
> +                imx908_out: endpoint {
> +                    data-lanes = <1 2 3 4>;
> +                    link-frequencies = /bits/ 64 <720000000>;
> +                    remote-endpoint = <&csi0_in>;
> +                };
> +            };
> +        };
> +    };
> +
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 55b3c2d7a78a..bb7adcfd4767 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25538,6 +25538,11 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
>  F:	drivers/media/i2c/imx678.c
>  
> +SONY IMX908 SENSOR DRIVER
> +M:	Lachlan Michael <lachlan.michael@sony.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> +
>  SONY MEMORYSTICK SUBSYSTEM
>  M:	Maxim Levitsky <maximlevitsky@gmail.com>
>  M:	Alex Dubov <oakad@yahoo.com>

-- 
Regards,

Laurent Pinchart