All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Karas <krzysztof.karas@intel.com>
To: <intel-gfx@lists.freedesktop.org>
Cc: <dri-devel@lists.freedesktop.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
	Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	Krzysztof Niemiec <krzysztof.niemiec@intel.com>,
	Krzysztof Karas <krzysztof.karas@intel.com>
Subject: [PATCH v3 0/8] drm/i915/selftests: Modernize printing in i915 selftests
Date: Fri, 28 Aug 2026 10:03:31 +0000	[thread overview]
Message-ID: <20260828100339.72304-1-krzysztof.karas@intel.com> (raw)

Currently, in many instances, i915 functions call pr_* macros
to write a message to the system log. This way of printing
lacks device context, which could be a valuable source of
information. Many files in DRM already use drm_* prints to
include that context, so it would be beneficial to do the same
for i915 as well. Start small and convert i915 selftests first.

I do not anticipate this series to pass BAT runs due to
filtering warnings and error messages in our CI. Since the
formatting is slightly different, expected messages will be
detected as new issues.

v3 (Janusz, sashiko):
- keep pr_* where no device exists;
- pass struct drm_device explicitly through selftest wrappers
  instead of casting void *data;
- fall back to pr_* when device is NULL, to avoid "NULL device"
  output;
- keep lines limited to 80 characters where possible;
- drop unrelated reformatting;
- introduce local drm_i915_private variable for multiple complex
  dereferences;

Krzysztof Karas (8):
  drm/i915/selftest: Fix a typo in alloc_workqueue call
  drm/i915/selftests: Use drm_* prints in live selftests
  drm/i915/selftests: Use drm_* prints in selftest helpers
  drm/i915/gt/selftests: Use drm_* prints in aggregated gt selftests
  drm/i915/gt/selftests: Use drm_* prints in gt standalone tests
  drm/i915/gt/selftests: Use drm_* prints in gt selftest helpers
  drm/i915/selftests: Use drm_* prints in selftest headers
  drm/i915/selftests: Add drm_device to selftest wrappers

 .../gpu/drm/i915/gem/selftests/huge_pages.c   |   4 +-
 .../i915/gem/selftests/i915_gem_client_blt.c  |   2 +-
 .../i915/gem/selftests/i915_gem_coherency.c   |   2 +-
 .../drm/i915/gem/selftests/i915_gem_context.c |   2 +-
 .../drm/i915/gem/selftests/i915_gem_dmabuf.c  |   4 +-
 .../drm/i915/gem/selftests/i915_gem_migrate.c |   2 +-
 .../drm/i915/gem/selftests/i915_gem_mman.c    |   4 +-
 .../drm/i915/gem/selftests/i915_gem_object.c  |   4 +-
 .../drm/i915/gem/selftests/i915_gem_phys.c    |   2 +-
 drivers/gpu/drm/i915/gt/selftest_context.c    |  35 +-
 drivers/gpu/drm/i915/gt/selftest_engine_cs.c  |  12 +-
 .../drm/i915/gt/selftest_engine_heartbeat.c   |  15 +-
 drivers/gpu/drm/i915/gt/selftest_engine_pm.c  |  60 +--
 drivers/gpu/drm/i915/gt/selftest_execlists.c  | 355 +++++++++++-------
 drivers/gpu/drm/i915/gt/selftest_gt_pm.c      |  36 +-
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c  |   2 +-
 drivers/gpu/drm/i915/gt/selftest_llc.c        |  29 +-
 drivers/gpu/drm/i915/gt/selftest_lrc.c        |   2 +-
 drivers/gpu/drm/i915/gt/selftest_migrate.c    |  69 ++--
 drivers/gpu/drm/i915/gt/selftest_mocs.c       |  14 +-
 drivers/gpu/drm/i915/gt/selftest_rc6.c        |  59 +--
 drivers/gpu/drm/i915/gt/selftest_reset.c      |  30 +-
 drivers/gpu/drm/i915/gt/selftest_ring.c       |   2 +-
 .../drm/i915/gt/selftest_ring_submission.c    |   2 +-
 drivers/gpu/drm/i915/gt/selftest_rps.c        | 297 ++++++++-------
 drivers/gpu/drm/i915/gt/selftest_slpc.c       | 105 ++++--
 drivers/gpu/drm/i915/gt/selftest_timeline.c   |   4 +-
 drivers/gpu/drm/i915/gt/selftest_tlb.c        |  41 +-
 .../gpu/drm/i915/gt/selftest_workarounds.c    | 106 ++++--
 drivers/gpu/drm/i915/gt/st_shmem_utils.c      |   2 +-
 drivers/gpu/drm/i915/gt/uc/selftest_guc.c     |   2 +-
 .../drm/i915/gt/uc/selftest_guc_hangcheck.c   |   2 +-
 .../drm/i915/gt/uc/selftest_guc_multi_lrc.c   |   2 +-
 drivers/gpu/drm/i915/i915_selftest.h          |  16 +-
 drivers/gpu/drm/i915/selftests/i915_active.c  |  14 +-
 drivers/gpu/drm/i915/selftests/i915_gem.c     |   2 +-
 .../gpu/drm/i915/selftests/i915_gem_evict.c   |  79 ++--
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 227 ++++++-----
 drivers/gpu/drm/i915/selftests/i915_perf.c    |  31 +-
 drivers/gpu/drm/i915/selftests/i915_request.c | 307 ++++++++-------
 .../gpu/drm/i915/selftests/i915_selftest.c    |  71 +++-
 .../gpu/drm/i915/selftests/i915_sw_fence.c    |   4 +-
 drivers/gpu/drm/i915/selftests/i915_syncmap.c |   2 +-
 drivers/gpu/drm/i915/selftests/i915_vma.c     | 261 ++++++++-----
 .../gpu/drm/i915/selftests/igt_flush_test.c   |   7 +-
 .../gpu/drm/i915/selftests/igt_live_test.c    |   6 +-
 drivers/gpu/drm/i915/selftests/igt_reset.c    |   5 +-
 .../drm/i915/selftests/intel_memory_region.c  |   6 +-
 .../i915/selftests/intel_scheduler_helpers.c  |   8 +-
 drivers/gpu/drm/i915/selftests/intel_uncore.c |  49 +--
 .../gpu/drm/i915/selftests/mock_gem_device.c  |   4 +-
 drivers/gpu/drm/i915/selftests/scatterlist.c  |   2 +-
 52 files changed, 1455 insertions(+), 955 deletions(-)

-- 
2.34.1


             reply	other threads:[~2026-08-28 10:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 10:03 Krzysztof Karas [this message]
2026-08-28 10:03 ` [PATCH v3 1/8] drm/i915/selftest: Fix a typo in alloc_workqueue call Krzysztof Karas
2026-08-28 14:24   ` Andi Shyti
2026-08-28 16:54   ` Andi Shyti
2026-08-28 10:03 ` [PATCH v3 2/8] drm/i915/selftests: Use drm_* prints in live selftests Krzysztof Karas
2026-08-28 14:34   ` Andi Shyti
2026-08-31  8:35     ` Jani Nikula
2026-08-28 16:41   ` Krzysztof Niemiec
2026-08-31  8:39     ` Jani Nikula
2026-08-28 10:03 ` [PATCH v3 3/8] drm/i915/selftests: Use drm_* prints in selftest helpers Krzysztof Karas
2026-08-28 15:58   ` Andi Shyti
2026-08-28 16:49   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 4/8] drm/i915/gt/selftests: Use drm_* prints in aggregated gt selftests Krzysztof Karas
2026-08-28 16:18   ` Andi Shyti
2026-09-03 12:39     ` Krzysztof Karas
2026-08-28 17:40   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 5/8] drm/i915/gt/selftests: Use drm_* prints in gt standalone tests Krzysztof Karas
2026-08-28 16:23   ` Andi Shyti
2026-08-28 18:02   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 6/8] drm/i915/gt/selftests: Use drm_* prints in gt selftest helpers Krzysztof Karas
2026-08-28 16:28   ` Andi Shyti
2026-08-28 18:06   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 7/8] drm/i915/selftests: Use drm_* prints in selftest headers Krzysztof Karas
2026-08-28 16:30   ` Andi Shyti
2026-08-28 18:08   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 8/8] drm/i915/selftests: Add drm_device to selftest wrappers Krzysztof Karas
2026-08-28 16:36   ` Andi Shyti
2026-08-28 11:31 ` ✗ i915.CI.BAT: failure for drm/i915/selftests: Modernize printing in i915 selftests (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260828100339.72304-1-krzysztof.karas@intel.com \
    --to=krzysztof.karas@intel.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=krzysztof.niemiec@intel.com \
    --cc=sebastian.brzezinka@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.