Re: [PATCH v3 5/8] drm/i915/gt/selftests: Use drm_* prints in gt standalone tests

[Andi Shyti <andi.shyti@kernel.org>]

Hi krzysztof,

...

> @@ -80,8 +83,9 @@ int live_rc6_manual(void *arg)
>  	res[1] = rc6_residency(rc6);
>  	rc0_freq = intel_rps_read_actual_frequency_fw(rps);
>  	if ((res[1] - res[0]) >> 10) {
> -		pr_err("RC6 residency increased by %lldus while disabled for 1000ms!\n",
> -		       (res[1] - res[0]) >> 10);
> +		drm_err(&i915->drm,
> +			"RC6 residency increased by %lldus while disabled for 1000ms!\n",
> +			(res[1] - res[0]) >> 10);

yeah... I think here we should be using gt_err()

>  		err = -EINVAL;
>  		goto out_unlock;
>  	}
> @@ -92,10 +96,12 @@ int live_rc6_manual(void *arg)
>  
>  		if (!rc0_power) {
>  			if (rc0_freq)
> -				pr_err("No power measured while in RC0! GPU Freq: %uMHz in RC0\n",
> -				       rc0_freq);
> +				drm_dbg(&i915->drm,
> +					"No power measured while in RC0! GPU Freq: %uMHz in RC0\n",
> +					rc0_freq);

this is moving from _err level to _dbg level.

Andi

>  			else
> -				pr_err("No power and freq measured while in RC0\n");
> +				drm_err(&i915->drm,
> +					"No power and freq measured while in RC0\n");
>  			err = -EINVAL;
>  			goto out_unlock;
>  		}