Re: [PATCH 1/2] dt-bindings: phy: Document Renesas Multi-Protocol PHY driver for R-Car X5H

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The description for `renesas,num-lanes` incorrectly states it applies to "each PHY input", which contradicts the hardware topology and the schema constraints.
--

commit ae58224156f0a1174aafe97692e6bf7123fdb20b
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>

dt-bindings: phy: Document Renesas Multi-Protocol PHY driver for R-Car X5H

This commit introduces device tree binding documentation for the Renesas
Multi-Protocol PHY found in the R-Car X5H SoC. It describes a multiplexing PHY
block that routes five inputs to four separate IO blocks.

> diff --git a/Documentation/devicetree/bindings/phy/renesas,rcar-gen5-mpphy.yaml b/Documentation/devicetree/bindings/phy/renesas,rcar-gen5-mpphy.yaml
> new file mode 100644
> index 0000000000000..2da8be2d3de82
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/renesas,rcar-gen5-mpphy.yaml

[ ... ]

> +  '#phy-cells':
> +    const: 1
> +
> +  renesas,num-lanes:
> +    description: PCIe lane count for each PHY input.

[Severity: Low]
Does this description accurately reflect the schema and hardware topology?

Looking at properties.renesas,num-lanes.description, the text states the
property applies to each PHY input, but the commit message notes there are
five inputs and four outputs. This appears to contradict the array
constraints immediately below it which enforce a maximum of 4 items. 

Should this description perhaps say "each PHY output" instead, or should the
array limits be updated to allow 5 items for the inputs?

> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    minItems: 4
> +    maxItems: 4
> +
> +  renesas,phy-type:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828192223.402422-1-marek.vasut+renesas@mailbox.org?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy